-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ScheduledJobs to CronJobs #36021
Conversation
@smarterclayton after registering ScheduledJobs with in |
It's hard to help debug without seeing the actual failure. |
nvmd, the rebase solved the problem |
@sttts fyi |
Jenkins GCE etcd3 e2e failed for commit 4483764c23de80a8542f758972d243e09937b884. Full PR test history. The magic incantation to run this job again is |
Jenkins GKE smoke e2e failed for commit 4483764c23de80a8542f758972d243e09937b884. Full PR test history. The magic incantation to run this job again is |
Jenkins GCI GKE smoke e2e failed for commit 4483764c23de80a8542f758972d243e09937b884. Full PR test history. The magic incantation to run this job again is |
Jenkins GCE e2e failed for commit 4483764c23de80a8542f758972d243e09937b884. Full PR test history. The magic incantation to run this job again is |
Jenkins Kubemark GCE e2e failed for commit 4483764c23de80a8542f758972d243e09937b884. Full PR test history. The magic incantation to run this job again is |
Jenkins GCI GCE e2e failed for commit 4483764c23de80a8542f758972d243e09937b884. Full PR test history. The magic incantation to run this job again is |
This is ready for review @smarterclayton, @janetkuo, @erictune @caesarxuchao I'd like to merge it for 1.5. The current state of this PR allows transparently accessing CronJobs or ScheduledJobs. Everything is stored as CronJobs, so no matter what you're creating it'll work in future versions. Unfortunately that also means what was created previously will have to be re-created, but I guess that's a minor issue. The only problem I'm struggling right now, is that I can't get SJ to appear in the swagger, which means |
Fixed bazel. |
Yeah, there was a lot of code added to make this work well for minions, and it only slightly rotted. |
Yup, since I know the knobs already I can volunteer to add it, if that's desirable. |
/lgtm |
Petset also changed the version from v1alpha1 to v1beta1, I bet that will complicate things. @erictune seems to be fine with abandoning petset completely. |
LGTM. Thanks. |
Rebased, re-applying the label back. |
Jenkins verification failed for commit fdcdc95c3255d7c81f13956d6e4eaf78e7aafae4. Full PR test history. The magic incantation to run this job again is |
Fixed the verification failure (codegen). |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
I went with @smarterclayton idea of registering named types in schema. This way we can support both the new (CronJobs) and old (ScheduledJobs) resource name. Fixes #32150.
fyi @erictune @caesarxuchao @janetkuo
Not ready yet, but getting close there...
Release note:
This change is![Reviewable](https://camo.githubusercontent.com/2d899f4291d07d3cd2fa4aaae1e3b243f164c23fce87d30a589ace0d496a444c/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)