Fix LBaaS version detection in openstack cloudprovider

[sjenning]

lbversion is the local variable used for version detection when os.lbOpts.LBVersion is not specified.

xref https://bugzilla.redhat.com/show_bug.cgi?id=1391837

@ncdc @derekwaynecarr @anguslees

---

This change is

[ncdc]

lgtm

[ncdc]

Update the unit test?

[sjenning]

@ncdc already a test for it. It is just skipped if there is no openstack env set. When env is set and run inside an openstack instance:

Before fix

Running tests for APIVersion: v1,apps/v1beta1,authentication.k8s.io/v1beta1,authorization.k8s.io/v1beta1,autoscaling/v1,batch/v1,batch/v2alpha1,certificates.k8s.io/v1alpha1,extensions/v1beta1,imagepolicy.k8s.io/v1alpha1,policy/v1beta1,rbac.authorization.k8s.io/v1alpha1,storage.k8s.io/v1beta1,federation/v1beta1
+++ [1104 18:31:18] Running tests without code coverage
--- FAIL: TestLoadBalancer (0.95s)
        openstack_test.go:216: Trying LBVersion = 'v1'
        openstack_test.go:216: Trying LBVersion = 'v2'
        openstack_test.go:216: Trying LBVersion = ''
        openstack_test.go:226: LoadBalancer() returned false - perhaps your stack doesn't support Neutron?
FAIL
FAIL    k8s.io/kubernetes/pkg/cloudprovider/providers/openstack 12.734s
Makefile:126: recipe for target 'test' failed
make: *** [test] Error 1

After fix

Running tests for APIVersion: v1,apps/v1beta1,authentication.k8s.io/v1beta1,authorization.k8s.io/v1beta1,autoscaling/v1,batch/v1,batch/v2alpha1,certificates.k8s.io/v1alpha1,extensions/v1beta1,imagepolicy.k8s.io/v1alpha1,policy/v1beta1,rbac.authorization.k8s.io/v1alpha1,storage.k8s.io/v1beta1,federation/v1beta1
+++ [1104 18:33:14] Running tests without code coverage
ok      k8s.io/kubernetes/pkg/cloudprovider/providers/openstack 13.068s

[anguslees]

Oops.

/lgtm

[k8s-github-robot]

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

[k8s-ci-robot]

Jenkins GCI GKE smoke e2e failed for commit 9875657. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[k8s-ci-robot]

Jenkins GKE smoke e2e failed for commit 9875657. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[k8s-ci-robot]

Jenkins GCI GCE e2e failed for commit 9875657. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[k8s-github-robot]

Automatic merge from submit-queue