-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GCI nodes mount non tmpfs, ext* & bind mounts using an external mounter #36267
Conversation
@@ -185,7 +192,7 @@ function install-kube-binary-config { | |||
chmod -R 755 "${kube_bin}" | |||
|
|||
# Install rkt binary to allow mounting storage volumes in GCI | |||
install-rkt | |||
install-gci-mounter-tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the comment too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@mtaufen could you also help review this PR? Thanks! |
835fbd0
to
ee30af7
Compare
@k8s-bot gci gke e2e test this |
For the following tests the cluster fails to initialize within 300 seconds:
The verification test is wants us to run
These two also timed out waiting for cluster initialization:
|
} | ||
|
||
# Garbage collect old rkt containers on exit | ||
trap gc EXIT | ||
|
||
${RKT_BINARY} run --stage1-name="coreos.com/rkt/stage1-fly:1.18.0" \ | ||
if [[ ! $(${RKT_BINARY} image list | grep ${MOUNTER_IMAGE}) ]]; then | ||
${RKT_BINARY} fetch file://${MOUNTER_ACI} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vishh this rkt fetch does not work because of signature issue. I found out a way to make this work by adding an option insecure-options
${RKT_BINARY} fetch --insecure-options=image file://${MOUNTER_ACI}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Fixing it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Jenkins GCI GKE smoke e2e failed for commit 96e23163d7c90191438e53fb739503bfe3e16917. Full PR test history. The magic incantation to run this job again is |
Jenkins GCI GCE e2e failed for commit 96e23163d7c90191438e53fb739503bfe3e16917. Full PR test history. The magic incantation to run this job again is |
Jenkins GCE etcd3 e2e failed for commit 96e23163d7c90191438e53fb739503bfe3e16917. Full PR test history. The magic incantation to run this job again is |
Jenkins Kubemark GCE e2e failed for commit 96e23163d7c90191438e53fb739503bfe3e16917. Full PR test history. The magic incantation to run this job again is |
Jenkins GKE smoke e2e failed for commit 96e23163d7c90191438e53fb739503bfe3e16917. Full PR test history. The magic incantation to run this job again is |
Jenkins unit/integration failed for commit 96e23163d7c90191438e53fb739503bfe3e16917. Full PR test history. The magic incantation to run this job again is |
Jenkins GCE Node e2e failed for commit 96e23163d7c90191438e53fb739503bfe3e16917. Full PR test history. The magic incantation to run this job again is |
Jenkins GCE e2e failed for commit 96e23163d7c90191438e53fb739503bfe3e16917. Full PR test history. The magic incantation to run this job again is |
Jenkins verification failed for commit 96e23163d7c90191438e53fb739503bfe3e16917. Full PR test history. The magic incantation to run this job again is |
…unter-scope"" This reverts commit 402116a.
Added a make rule `make upload` to audit and automate release artifact uploads to GCS. Signed-off-by: Vishnu kannan <vishnuk@google.com>
Signed-off-by: Vishnu kannan <vishnuk@google.com>
WRT verification test, you probably need to:
|
Update the gci-mounter sha1 number
…ring runtime Signed-off-by: Vishnu kannan <vishnuk@google.com>
Signed-off-by: Vishnu kannan <vishnuk@google.com>
96e2316
to
5ad53bb
Compare
@k8s-bot node e2e test this |
@k8s-bot gci gce e2e test this |
@k8s-bot gci gke e2e test this |
The tests passed. I rerun a few just to make sure. @mtaufen Do you have any other comments? Otherwise, LGTM |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
Automatic merge from submit-queue Make GCI nodes mount non tmpfs, ext* & bind mounts using an external mounter This PR downloads the stage1 & gci-mounter ACIs as part of cluster bring up instead of downloading them dynamically from gcr.io, which was the cause for kubernetes#36206. I have also optimized the containerized mounter to pre-load the mounter image once to avoid fetch latency while using it. Original PR which got reverted: kubernetes#35821 ```release-note GCI nodes use an external mounter script to mount NFS & GlusterFS storage volumes ``` @mtaufen Node e2e is not re-enabled in this PR. cc @jingxu97
This PR downloads the stage1 & gci-mounter ACIs as part of cluster bring up instead of downloading them dynamically from gcr.io, which was the cause for #36206.
I have also optimized the containerized mounter to pre-load the mounter image once to avoid fetch latency while using it.
Original PR which got reverted: #35821
@mtaufen Node e2e is not re-enabled in this PR.
cc @jingxu97
This change is![Reviewable](https://camo.githubusercontent.com/2d899f4291d07d3cd2fa4aaae1e3b243f164c23fce87d30a589ace0d496a444c/68747470733a2f2f72657669657761626c652e6b756265726e657465732e696f2f7265766965775f627574746f6e2e737667)