Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PodDisruptionBudget in Kubectl #36495

Merged
merged 3 commits into from
Nov 10, 2016

Conversation

mwielgus
Copy link
Contributor

@mwielgus mwielgus commented Nov 9, 2016

Based on:

#35287

cc: @davidopp @soltysh @wojtek-t


This change is Reviewable

@mwielgus mwielgus added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 9, 2016
@mwielgus mwielgus added this to the v1.5 milestone Nov 9, 2016
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 9, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 5e83188. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@soltysh
Copy link
Contributor

soltysh commented Nov 9, 2016

@k8s-bot unit test this flake #36351

@soltysh
Copy link
Contributor

soltysh commented Nov 9, 2016

LGTM

@soltysh soltysh added cla: human-approved lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed cla: no labels Nov 9, 2016
@mwielgus mwielgus added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 9, 2016
@saad-ali saad-ali added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 9, 2016
@saad-ali saad-ali removed this from the v1.5 milestone Nov 9, 2016
@saad-ali
Copy link
Member

saad-ali commented Nov 9, 2016

Removing milestone and marking do-not-merge until we have had a chance to review this feature's post-code freeze exception (https://groups.google.com/forum/#!topic/kubernetes-milestone-burndown/RaiyVVkbKaU).

@0xmichalis
Copy link
Contributor

@kubernetes/kubectl

@davidopp
Copy link
Member

davidopp commented Nov 9, 2016

LGTM

Personally I would have put current (and maybe total) in "get" as well as describe, but I guess this is OK.

@mwielgus mwielgus modified the milestone: v1.5 Nov 9, 2016
@soltysh
Copy link
Contributor

soltysh commented Nov 9, 2016

Personally I would have put current (and maybe total) in "get" as well as describe, but I guess this is OK.

This can be easily added in the next release. At this point we should merge this in as is.

@saad-ali
Copy link
Member

saad-ali commented Nov 9, 2016

Removing milestone and marking do-not-merge until we have had a chance to review this feature's post-code freeze exception (https://groups.google.com/forum/#!topic/kubernetes-milestone-burndown/RaiyVVkbKaU).

The request for exception to 1.5 release code freeze for the "PodDisruptionBudget" feature has been approved. Adding 1.5 milestone and removing do-not-merge label.

@saad-ali saad-ali removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 9, 2016
@saad-ali saad-ali added this to the v1.5 milestone Nov 9, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 5d894d5 into kubernetes:master Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants