Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource printer and describer for PodDisruptionBudget #35287

Closed
wants to merge 1 commit into from
Closed

Add resource printer and describer for PodDisruptionBudget #35287

wants to merge 1 commit into from

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Oct 21, 2016 •
edited by k8s-oncall

@davidopp || @mml ptal

This change is Reviewable

@soltysh soltysh added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 21, 2016
@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit c283531. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@davidopp
Copy link
Member

@mwielgus

@davidopp davidopp assigned mwielgus and unassigned davidopp Oct 22, 2016
mwielgus
mwielgus reviewed Oct 22, 2016
View reviewed changes
pkg/kubectl/describe.go
clientset.Interface
}

func (p *PodDisruptionBudgetDescriber) Describe(namespace, name string, describerSettings DescriberSettings) (string, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should print some status information as well. However I have a pr in flight that changes the status struct a bit #34546. The PR should be merged on Monday.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assigned as the reviewer for that PR and didn't know it was ready to review. Do yuo want me to review it? (How was it going to be merged on Monday without a review?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for the other PR to land and will update this accordingly, in that case.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit a1b7ccb. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit a1b7ccb. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@mwielgus
Copy link
Contributor

mwielgus commented Nov 8, 2016

We need this PR back in shape ASAP. I completely forgot about it. If you don't have time to work on this would it be ok for me to cherry-pick your commit and add some fixes on top of it?

@mwielgus mwielgus mentioned this pull request Nov 9, 2016
Merged
@soltysh
Copy link
Contributor Author

soltysh commented Nov 9, 2016

Superseded by #36495.

@soltysh soltysh closed this Nov 9, 2016
@soltysh soltysh deleted the pdb_printers branch November 9, 2016 15:20
k8s-github-robot pushed a commit that referenced this pull request Nov 10, 2016
Merge pull request #36495 from mwielgus/kubectl_pdb
5d894d5 
Automatic merge from submit-queue

Support for PodDisruptionBudget in Kubectl

Based on:

#35287

cc: @davidopp @soltysh @wojtek-t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidopp davidopp davidopp left review comments

@mwielgus mwielgus mwielgus left review comments

Assignees

@mwielgus mwielgus

Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@soltysh @k8s-ci-robot @davidopp @mwielgus @googlebot @k8s-github-robot