Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenAPI spec generator to enable all APIs #36684

Merged
merged 2 commits into from
Nov 14, 2016

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented Nov 12, 2016

scheduledjob/cronjob is missing in the OpenAPI spec located in api/openapi-spec/swagger.json. Root cause is the API was not enabled when we generate this file in hack/update-openapi-spec.sh.

This change is only effect static swagger.json file in our source tree but the documentation @pwittrock working on and client-python I am working on depends on it. We can sure hack our way through having this in our components, but it look cleaner to have it in 1.5 specially because there is no runtime behavior change of any kind.

Fixes #36682


This change is Reviewable

@mbohlool mbohlool added this to the v1.5 milestone Nov 12, 2016
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Nov 12, 2016
@smarterclayton
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2016
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 12, 2016
@dims
Copy link
Member

dims commented Nov 12, 2016

@smarterclayton @saad-ali : looks like this got stuck because of "release-note-label-needed" tag. Can you please clear that when you get a chance?

@saad-ali saad-ali added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Nov 14, 2016
@saad-ali
Copy link
Member

Bug fix ok for post-code-freeze merge.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit c15758e into kubernetes:master Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants