Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better compat with very old iptables (e.g. CentOS 6) #37594

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Better compat with very old iptables (e.g. CentOS 6) #37594

merged 1 commit into from
Dec 7, 2016

Conversation

thockin
Copy link
Member

@thockin thockin commented Nov 29, 2016 •
edited
Loading

Fixes reported issue with CentOS6 iptables 1.4.7 (ancient)

Older iptables expanded things like 0x4000 into 0x00004000, which defeats the
fallback "check" logic.

Fixes #37416

This change is Reviewable

@thockin
Better compat with very old iptables
35cc60e 
Older iptables expanded things like 0x4000 into 0x00004000, which defeats the
fallback "check" logic.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2016
@thockin thockin mentioned this pull request Nov 29, 2016
Closed
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Nov 29, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 35cc60e. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins kops AWS e2e failed for commit 35cc60e. Full PR test history.

The magic incantation to run this job again is @k8s-bot kops aws e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@smarterclayton
Copy link
Contributor

@kubernetes/sig-network needs an owner who is not me

@thockin thockin assigned dcbw and unassigned smarterclayton Nov 29, 2016
@caseydavenport
Copy link
Member

This LGTM.

Not sure what's up with gke/kops - Let's give em another try.

@k8s-bot kops aws e2e test this
@k8s-bot gci gke e2e test this

@thockin thockin added this to the v1.5 milestone Nov 29, 2016
@thockin thockin added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Nov 29, 2016
@thockin thockin changed the title Better compat with very old iptables Better compat with very old iptables (e.g. CentOS 6) Nov 29, 2016
@thockin
Copy link
Member Author

thockin commented Nov 29, 2016

To be clear, this is gross, but it's already in a sketchy fallback path...

@thockin
Copy link
Member Author

thockin commented Nov 29, 2016

not a 1.5 blocker - ok for 1.5.1.

@feiskyer
Copy link
Member

LGTM.

@thockin thockin added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherrypick-candidate labels Dec 5, 2016
@dims
Copy link
Member

dims commented Dec 6, 2016

@k8s-bot test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 35cc60e. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@feiskyer
Copy link
Member

feiskyer commented Dec 6, 2016

@k8s-bot node e2e test this

@dims
Copy link
Member

dims commented Dec 6, 2016

@k8s-bot gce etcd3 e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 35cc60e. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@dims
Copy link
Member

dims commented Dec 6, 2016

@k8s-bot gce etcd3 e2e test this

@dims
Copy link
Member

dims commented Dec 6, 2016

@k8s-bot cvm gce e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 35cc60e. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@dims
Copy link
Member

dims commented Dec 7, 2016

@k8s-bot cvm gce e2e test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 38194, 37594, 38123, 37831, 37084)

@k8s-github-robot k8s-github-robot merged commit aeb81f2 into kubernetes:master Dec 7, 2016
@saad-ali saad-ali mentioned this pull request Dec 7, 2016
Closed
@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 8, 2016
@saad-ali saad-ali mentioned this pull request Dec 8, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Dec 8, 2016
Merge pull request #38343 from saad-ali/automated-cherry-pick-of-#37594-
faf84b7 
#38276-#37009-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #37594 #38276 #37009 upstream release 1.5

Batch cherry pick PRs #37594 #38276 #37009 from master to release-1.5 branch.

PR #37009 had merge conflicts that needed to be resolved.

CC Original PR Authors: @thockin @mbohlool @mwielgus @sjenning
@thockin thockin deleted the fix-old-iptables-mark-extra-zeroes branch August 14, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caseydavenport caseydavenport

@dcbw dcbw

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@thockin @k8s-ci-robot @smarterclayton @caseydavenport @feiskyer @dims @k8s-github-robot @saad-ali @dcbw