Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable containerized mounter only for nfs and glusterfs types #37990

Merged
merged 1 commit into from
Dec 3, 2016
Merged

Enable containerized mounter only for nfs and glusterfs types #37990

merged 1 commit into from
Dec 3, 2016

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Dec 2, 2016

This change is to only enable containerized mounter for nfs and
glusterfs types. For other types such as tmpfs, ext2/3/4 or empty type,
we should still use mount from $PATH to minimize the effect of containerized mounter.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 2, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@jingxu97 jingxu97 added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 2, 2016
@jingxu97 jingxu97 self-assigned this Dec 2, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit d2e41e72989817ceff0efa58b5e45f8e2b997630. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit d2e41e72989817ceff0efa58b5e45f8e2b997630. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit d2e41e72989817ceff0efa58b5e45f8e2b997630. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit d2e41e72989817ceff0efa58b5e45f8e2b997630. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit d2e41e72989817ceff0efa58b5e45f8e2b997630. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit d2e41e72989817ceff0efa58b5e45f8e2b997630. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit d2e41e72989817ceff0efa58b5e45f8e2b997630. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit d2e41e72989817ceff0efa58b5e45f8e2b997630. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit d2e41e72989817ceff0efa58b5e45f8e2b997630. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Dec 2, 2016
@jingxu97
Enable containerized mounter only for nfs and glusterfs types
37136e9 
This change is to only enable containerized mounter for nfs and
glusterfs types. For other types such as tmpfs, ext2/3/4 or empty type,
we should still use mount from $PATH
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit d2e41e72989817ceff0efa58b5e45f8e2b997630. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@saad-ali saad-ali added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Dec 2, 2016
@saad-ali saad-ali added this to the v1.5 milestone Dec 2, 2016
@saad-ali
Copy link
Member

saad-ali commented Dec 2, 2016

Thanks Jing!

@saad-ali saad-ali assigned saad-ali and unassigned jingxu97 Dec 2, 2016
@saad-ali
Copy link
Member

saad-ali commented Dec 2, 2016

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2016
@saad-ali
Copy link
Member

saad-ali commented Dec 2, 2016

@jessfraz FYI, after we've cherry-picked this to 1.5, it must be cherry picked to 1.4 as well and be part of 1.4.x release being cut Friday (along with other storage changes)

@k8s-ci-robot
Copy link
Contributor

Jenkins kops AWS e2e failed for commit 37136e9. Full PR test history.

The magic incantation to run this job again is @k8s-bot kops aws e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 37997, 37939, 37990, 36700, 37258)

@k8s-github-robot k8s-github-robot merged commit ef8a8be into master Dec 3, 2016
@saad-ali saad-ali mentioned this pull request Dec 3, 2016
Closed
@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 3, 2016
@saad-ali saad-ali mentioned this pull request Dec 3, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Dec 3, 2016
Merge pull request #38038 from saad-ali/automated-cherry-pick-of-#35272-
3787c91 
#37834-#37723-#37668-#37721-#37381-#37944-#37997-#37939-#37990-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #35272 #37834 #37723 #37668 #37721 #37381 #37944 #37997 #37939 #37990 upstream release 1.5

Batch cherry pick PRs #35272 #37834 #37723 #37668 #37721 #37381 #37944 #37997 #37939 #37990 from master to release-1.5 branch.

PRs #37997 had merge conflicts that needed to be resolved (due to large PRs that merged to master but not 1.5, see this for details)

CC PR Authors: @yarntime @ixdy @mtaufen @ymqytw @derekwaynecarr @jszczepkowski @Kargakis @foxish @jingxu97
@thockin thockin deleted the Dec/mounttype branch December 7, 2016 06:47
@jsafrane jsafrane mentioned this pull request Feb 20, 2017
Closed
@jingxu97 jingxu97 mentioned this pull request Aug 14, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saad-ali saad-ali

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jingxu97 @k8s-reviewable @k8s-ci-robot @saad-ali @k8s-github-robot