Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove needless env var in OpenStack provider #38433

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Remove needless env var in OpenStack provider #38433

merged 1 commit into from
Jan 4, 2017
+9 −11

Conversation

yuanying
Copy link
Contributor

@yuanying yuanying commented Dec 9, 2016

What this PR does / why we need it:

If we use openstack provider to set up k8s cluster using kube-up script,
TENANT_ID environment variable is needed.
But to configure TENANT_ID is very annoying because this value is not static by each env.
This patch uses TENANT_NAME instead of TENANT_ID

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Since TENANT_NAME is unique if we use keystone v2 api,
so TENANT_ID is not needed if TENANT_NAME is provided
to configure OpenStack provider.
And also to set TENANT_ID is annoying to develop, because
TENANT_ID is not static by each environment.
This patch remove dependency of TENANT_ID and simply use
TENANT_NAME.

@yuanying
Remove needless env var in OpenStack provider
d5e039c 
Since `TENANT_NAME` is unique if we use keystone v2 api,
so `TENANT_ID` is not needed if `TENANT_NAME` is provided
to configure OpenStack provider.
And also to set `TENANT_ID` is annoying to develop, because
`TENANT_ID` is not static by each environment.
This patch remove dependency of `TENANT_ID` and simply use
`TENANT_NAME`.
@k8s-ci-robot
Copy link
Contributor

Hi @yuanying. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Dec 9, 2016
@jbeda
Copy link
Contributor

jbeda commented Dec 11, 2016 •
edited
Loading

@k8s-bot ok to test

@jbeda jbeda added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Dec 11, 2016
@jbeda
Copy link
Contributor

jbeda commented Dec 11, 2016

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2016
@xsgordon
Copy link

@idvoretskyi can you add the sig/openstack label please?

/cc @kubernetes/sig-openstack

@idvoretskyi idvoretskyi added the area/provider/openstack Issues or PRs related to openstack provider label Dec 15, 2016
@zmerlynn
Copy link
Member

zmerlynn commented Jan 3, 2017

@k8s-bot test this

@k8s-ci-robot
Copy link
Contributor

Jenkins kops AWS e2e failed for commit d5e039c. Full PR test history.

The magic incantation to run this job again is @k8s-bot kops aws e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zmerlynn
Copy link
Member

zmerlynn commented Jan 4, 2017

@k8s-bot kops aws e2e test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 38433, 36245)

@k8s-github-robot k8s-github-robot merged commit b202ebb into kubernetes:master Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguslees anguslees anguslees approved these changes

@codevulture codevulture codevulture approved these changes

Assignees

@jbeda jbeda

Labels
area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@yuanying @k8s-ci-robot @k8s-reviewable @jbeda @xsgordon @zmerlynn @k8s-github-robot @anguslees @codevulture @idvoretskyi