-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vendor: Update github.com/evanphx/json-patch #40387
Conversation
Updates github.com/evanphx/json-patch dependency to a version that doesn't crash when handling an invalid json patch. Includes fix from evanphx/json-patch#35 Fix kubernetes#40218
Hi @mikkeloscar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files: We suggest the following people: |
@k8s-bot ok to test |
Running
I suspect this is similar to the problem in #41269 I'm setting up a clean GOPATH according to this: https://github.com/kubernetes/community/blob/master/contributors/devel/godep.md#using-godep I and the
|
The error in Jenkins GCE etcd3 e2e seems to be a flake: #42099 |
@k8s-bot gce etcd3 e2e test this |
@k8s-bot verify test this |
@mikkeloscar: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Removing issue from 1.6 milestone since code freeze has begun:
/cc @kubernetes/release-team @kubernetes/kubernetes-release-managers |
Moving this issue into the 1.7 milestone @ethernetdan cc: @kubernetes/kubernetes-release-managers |
This is a crash blocker. |
This doesn't pass |
Is there any better way to handle godep than this guide?: https://github.com/kubernetes/community/blob/master/contributors/devel/godep.md I'm running it from a completely clean $GOPATH as suggested but only getting this far:
This PR only changes a single sha in |
If you want to restore godeps, you have to use |
regenerated and squashed the files in #43096 |
I ran |
Closed in favor of #43096 |
Automatic merge from submit-queue vendor: Update github.com/evanphx/json-patch Regenerated files for kubernetes#40387 Fixes kubernetes#40218
Automatic merge from submit-queue vendor: Update github.com/evanphx/json-patch Regenerated files for kubernetes/kubernetes#40387 Fixes #40218 Kubernetes-commit: a19210f418a4a245b0c1319f88c14dc66018f10d
Updates
github.com/evanphx/json-patch
dependency to a version that doesn't crash when handling an invalid json patch.Includes fix from evanphx/json-patch#35
Fix #40218