Default target storage in etcd #41065
Conversation
wojtek-t
added
the
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: wojtek-t Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Please add more context in the PR description. It's unclear to people without context what this PR is supposed to fix. |
|
@fgrzadkowski - added description. PTAL |
| sed -i -e "s@{{ *storage_backend *}}@${STORAGE_BACKEND:-}@g" "${temp_file}" | ||
| if [[ "${STORAGE_BACKEND:-}" == "etcd3" ]]; then | ||
| if [[ "${STORAGE_BACKEND:-etcd3}" == "etcd3" ]]; then |
There was a problem hiding this comment.
I don't understand this. Shouldn't we just default STORAGE_BACKEND to etcdv3 in one place, rather than default it in all the places where you'd use it?
There was a problem hiding this comment.
Ok, I understand this one.
However it means that the default you have here has to be inline with whatever you set as the default in manifest file. Is there anyway we can just read the default value from manifest file using sed?
There was a problem hiding this comment.
We can do it using "grep + sed". Will fix. (I agree it makes sense, especially since we are touching the same manifest file here).
wojtek-t
force-pushed
the
default_target_storage_in_etcd
branch
from
ab179a9
to
2bd2cf7
Compare
wojtek-t
force-pushed
the
default_target_storage_in_etcd
branch
from
2bd2cf7
to
a2a861b
Compare
|
@wojtek-t: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@k8s-bot cross build test this, issue: #IGNORE (timeout) |
|
@fgrzadkowski - PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
I thought I'd clicked "Send" on my review yesterday, but I guess I did not. My only comment was the same as @fgrzadkowski's. |
|
Automatic merge from submit-queue (batch tested with PRs 40873, 40948, 39580, 41065, 40815) |
To make etcd v2->v3 upgrade work correctly, we need to correctly set the "TARGET_STORAGE" env var. Since in head we are defaulting to etcd v3, this PR is defaulting also that env var to etcd3, so that by default upgrade works fine.
@fgrzadkowski @gmarek