Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch serviceaccounts controller to generated shared informers #41425

Merged
merged 1 commit into from Feb 16, 2017
Merged

Switch serviceaccounts controller to generated shared informers #41425

merged 1 commit into from Feb 16, 2017

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Feb 14, 2017

Originally part of #40097

cc @deads2k @sttts @liggitt @smarterclayton @gmarek @wojtek-t @timothysc @kubernetes/sig-scalability-pr-reviews

@ncdc ncdc added release-note-none Denotes a PR that doesn't merit a release note. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. labels Feb 14, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2017
@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 14, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@luxas
Copy link
Member

luxas commented Feb 14, 2017

@ncdc Is this a dependency for #41281? cc @ericchiang

@ncdc
Copy link
Member Author

ncdc commented Feb 14, 2017

@luxas not that I know of? I'm methodically working my way through most of the code that isn't using shared informers and converting them to use the generated shared informers.

@ncdc ncdc force-pushed the shared-informers-10-serviceaccount branch from f7d4e1e to 65fe722 Compare February 14, 2017 19:21
@ncdc
Copy link
Member Author

ncdc commented Feb 14, 2017

@k8s-bot unit test this

@smarterclayton
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

@smarterclayton: you can't LGTM a PR unless you are an assignee.

In response to this comment:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: ncdc, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2017
@ncdc ncdc added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 84bab78 into kubernetes:master Feb 16, 2017
@ncdc ncdc deleted the shared-informers-10-serviceaccount branch April 18, 2017 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markturansky markturansky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ncdc @k8s-reviewable @luxas @smarterclayton @k8s-ci-robot @k8s-github-robot @markturansky