Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove everything that is not new from batch/v2alpha1 #41890

Merged
merged 4 commits into from
Mar 7, 2017
Merged

Remove everything that is not new from batch/v2alpha1 #41890

merged 4 commits into from
Mar 7, 2017

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 22, 2017

Fixes #37166.

@lavalamp you've asked for it
@erictune this is a prereq for moving CronJobs to beta. I initially planned to put all in one PR, but after I did that I figured out it'll be easier to review separately. ptal

@kubernetes/api-approvers @kubernetes/sig-api-machinery-pr-reviews ptal

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 22, 2017
@soltysh soltysh added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 22, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Feb 22, 2017

@k8s-bot bazel test this

@soltysh
Copy link
Contributor Author

soltysh commented Feb 22, 2017

@kubernetes/sig-apps-api-reviews ptal as well

@soltysh soltysh mentioned this pull request Feb 22, 2017
Merged
@soltysh soltysh added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Feb 22, 2017
@soltysh soltysh added this to the v1.6 milestone Feb 23, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Feb 23, 2017

Rebased.

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 23, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Feb 27, 2017

Updated bazel build.

@soltysh soltysh force-pushed the issue37166 branch 3 times, most recently from 4063967 to f3eddba Compare February 27, 2017 16:06
@soltysh
Copy link
Contributor Author

soltysh commented Feb 27, 2017

We were still using old client in e2e tests, which forced using batch/v2alpha1, but currently client is smart enough to handle those manually. The last commit removes that part.

@smarterclayton
Copy link
Contributor

smarterclayton commented Mar 5, 2017 via email

@smarterclayton
Copy link
Contributor

I classify this as a serious bug (exposing new types accidentally).

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Mar 6, 2017

Rebased.

@soltysh
Copy link
Contributor Author

soltysh commented Mar 6, 2017

@k8s-bot bazel test this issue #39975

janetkuo
janetkuo approved these changes Mar 7, 2017
View reviewed changes
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM. @smarterclayton may have more comments

@smarterclayton
Copy link
Contributor

/lgtm

as well

@smarterclayton smarterclayton added this to the v1.6 milestone Mar 7, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: janetkuo, smarterclayton, soltysh

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @lavalamp
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor Author

soltysh commented Mar 7, 2017

The PR was lgtm-ed by both @smarterclayton and @janetkuo, not sure why bot didn't caught it. Adding lgtm label manually.

@soltysh soltysh added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 7, 2017
@soltysh
Copy link
Contributor Author

soltysh commented Mar 7, 2017

@k8s-bot verify test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

@soltysh: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins kops AWS e2e 591b2e0 link @k8s-bot kops aws e2e test this
Jenkins non-CRI GCE e2e 591b2e0 link @k8s-bot non-cri e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 41890, 42593, 42633, 42626, 42609)

@k8s-github-robot k8s-github-robot merged commit ed04316 into kubernetes:master Mar 7, 2017
@soltysh soltysh mentioned this pull request Mar 7, 2017
Merged
@soltysh soltysh deleted the issue37166 branch March 8, 2017 07:47
@soltysh soltysh mentioned this pull request Mar 14, 2017
Closed
k8s-github-robot pushed a commit that referenced this pull request Apr 13, 2017
Merge pull request #42663 from soltysh/37166_followup
868eb74 
Automatic merge from submit-queue

Add default information to CronJobSpec

This is requested followup to #41890

@smarterclayton @janetkuo ptal
vdemeester pushed a commit to vdemeester/kubernetes that referenced this pull request Aug 16, 2017
Merge pull request kubernetes#41901 from soltysh/cronjobs_beta
4032896 
Automatic merge from submit-queue

Promote CronJobs to batch/v1beta1 - just the API

This PR promotes CronJobs to beta.

@erictune @kubernetes/sig-apps-api-reviews @kubernetes/api-approvers ptal

This builds on top of kubernetes#41890 and needs kubernetes#40932 as well

```release-note
Promote CronJobs to batch/v1beta1.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton smarterclayton left review comments

@janetkuo janetkuo janetkuo approved these changes

Assignees

@smarterclayton smarterclayton

@janetkuo janetkuo

@erictune erictune

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/batch area/workload-api/cronjob cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-blocker release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@soltysh @k8s-reviewable @smarterclayton @janetkuo @ethernetdan @liggitt @k8s-github-robot @k8s-ci-robot @erictune