Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate ConfigMapRef and SecretRef name #42083

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Validate ConfigMapRef and SecretRef name #42083

merged 1 commit into from
Apr 3, 2017

Conversation

fraenkel
Copy link
Contributor

@fraenkel fraenkel commented Feb 24, 2017 •
edited

fixes #42037

Release note:

When creating a container using envFrom,
1. validate the name of the ConfigMap in a ConfigMapRef
2. validate the name of the Secret in a SecretRef

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Feb 24, 2017
@fraenkel
Copy link
Contributor Author

@k8s-bot cvm gce e2e test this

1 similar comment
@fraenkel
Copy link
Contributor Author

@k8s-bot cvm gce e2e test this

@fraenkel
Copy link
Contributor Author

Reported failure #41889

@fraenkel
Copy link
Contributor Author

@k8s-bot non-cri e2e test this

@gmarek
Copy link
Contributor

gmarek commented Feb 27, 2017

/lgtm - @erictune for approval

@gmarek gmarek added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note-label-needed labels Feb 27, 2017
@gmarek
Copy link
Contributor

gmarek commented Feb 27, 2017

@fraenkel - I think it deserves a release note.

@fraenkel
Copy link
Contributor Author

@gmarek done

@gmarek gmarek added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Feb 27, 2017
@gmarek
Copy link
Contributor

gmarek commented Feb 27, 2017

Thanks @fraenkel. Now we need to wait for @erictune

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 27, 2017 •
edited

Is this function new in 1.6? Or are there backwards compatibility considerations?

@fraenkel
Copy link
Contributor Author

All of this is new for 1.6, the envFrom stuff.

@smarterclayton
Copy link
Contributor

/approve

@smarterclayton
Copy link
Contributor

I asked because we can't tighten validation in many cases (because it's not necessarily backwards compatible)

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2017
@gmarek
Copy link
Contributor

gmarek commented Apr 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fraenkel, gmarek, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 42038, 42083)

@k8s-github-robot k8s-github-robot merged commit 7068458 into kubernetes:master Apr 3, 2017
@k8s-ci-robot
Copy link
Contributor

@fraenkel: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins kops AWS e2e 62bd5d3 link @k8s-bot kops aws e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

name of envFrom.configMapRef need validate when create pod
6 participants
@fraenkel @k8s-reviewable @gmarek @smarterclayton @k8s-github-robot @k8s-ci-robot