Use namespace from context #42652
Merged
Use namespace from context #42652
+39
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
the
size/M
|
This change is |
|
cc @kubernetes/sig-auth-pr-reviews |
liggitt
added
kind/bug
deads2k
reviewed
Mar 7, 2017
| @@ -47,12 +47,17 @@ func (s *Storage) Create(ctx genericapirequest.Context, obj runtime.Object) (run | |||
| return s.StandardStorage.Create(ctx, obj) | |||
| } | |||
|
|
|||
| namespace, ok := genericapirequest.NamespaceFrom(ctx) | |||
There was a problem hiding this comment.
This looks weird when you're reading it. Explain why we pull the namespace out here.
|
lgtm, but I'd like an explanatory comment. Nearly everywhere else, the object is considered the source of truth, so this looks weird. |
|
#42639 flake |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: deads2k, liggitt Needs approval from an approver in each of these OWNERS Files:
We suggest the following people: |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42653
Updates rbac_test.go to submit objects without namespaces set, which matches how actual objects are submitted to the API.