Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vsphere selinux support #42973

Merged
merged 1 commit into from Apr 3, 2017
Merged

Fix vsphere selinux support #42973

merged 1 commit into from Apr 3, 2017

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Mar 13, 2017 •
edited by enisoc

Managed flag must be true for SELinux relabelling to work
for vsphere.

Fixes #42972

Fix [vSphere volumes in SELinux environment](https://github.com/kubernetes/kubernetes/issues/42972).

@gnufied
Fix vsphere selinux support
a4a3d20 
Managed flag must be true for SELinux relabelling to work
for vsphere.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@gnufied
Copy link
Member Author

gnufied commented Mar 13, 2017

/assign @kerneltime

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Mar 13, 2017
@gnufied gnufied mentioned this pull request Mar 13, 2017
Closed
@kerneltime
Copy link

/approve

@kerneltime
Copy link

@gnufied can you elaborate on the testing done?

@kerneltime
Copy link

cc @divyenpatel @BaluDontu @luomiao

@gnufied
Copy link
Member Author

gnufied commented Mar 13, 2017 •
edited

@kerneltime I have only manually verified this, but after this patch the selinux label look like:

drwxrwsr-x. root 10000100 system_u:object_r:svirt_sandbox_file_t:s0:c618,c916 pvc-2f99f7e3-079e-11e7-9e54-005056a56eb9

And before:

drwxrwsr-x. root 10000100 system_u:object_r:unlabeled_t:s0 pvc-4dab1b7c-05c6-11e7-92e7-005056a56eb9

You can see new volume has proper label svirt_sandbox_file_t now.

@eparis eparis self-assigned this Mar 13, 2017
@eparis
Copy link
Contributor

eparis commented Mar 13, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 13, 2017
@kerneltime
Copy link

/lgtm

1 similar comment
@BaluDontu
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@BaluDontu: you can't LGTM a PR unless you are an assignee.

In response to this comment:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnufied
Copy link
Member Author

gnufied commented Apr 3, 2017

Unit test flaked on #37982

@gnufied
Copy link
Member Author

gnufied commented Apr 3, 2017

@k8s-bot unit test this

@gnufied
Copy link
Member Author

gnufied commented Apr 3, 2017

@k8s-bot non-cri e2e test this

@saad-ali
Copy link
Member

saad-ali commented Apr 3, 2017

/lgtm
/approve

@saad-ali saad-ali added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Apr 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BaluDontu, eparis, gnufied, kerneltime, saad-ali

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2017
@saad-ali saad-ali added this to the v1.6 milestone Apr 3, 2017
@eparis
Copy link
Contributor

eparis commented Apr 3, 2017

@saad-ali FYI /lgtm implies /approve. Save yourself a line of typing.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 538c5c7 into kubernetes:master Apr 3, 2017
@k8s-ci-robot
Copy link
Contributor

@gnufied: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins non-CRI GCE e2e a4a3d20 link @k8s-bot non-cri e2e test this
Jenkins GCI GCE e2e a4a3d20 link @k8s-bot gci gce e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@divyenpatel
Copy link
Member

@gnufied Can you cherry pick this change to release 1.5 and 1.4 branch?

This was referenced Apr 4, 2017
Merged
Merged
Closed
@gnufied
Copy link
Member Author

gnufied commented Apr 4, 2017

@divyenpatel done!

k8s-github-robot pushed a commit that referenced this pull request Apr 4, 2017
Merge pull request #44013 from gnufied/automated-cherry-pick-of-#4297…
2b9ddad 
…3-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #42973

Cherry pick of #42973 on release-1.6.

#42973: Fix vsphere selinux support

```release-note
Fix [vSphere volumes in SELinux environment](#42972).
```
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@enisoc enisoc added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 13, 2017
mintzhao pushed a commit to mintzhao/kubernetes that referenced this pull request Jun 1, 2017
Merge pull request kubernetes#44013 from gnufied/automated-cherry-pic…
ad8e398 
…k-of-#42973-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of kubernetes#42973

Cherry pick of kubernetes#42973 on release-1.6.

kubernetes#42973: Fix vsphere selinux support

```release-note
Fix [vSphere volumes in SELinux environment](kubernetes#42972).
```
k8s-github-robot pushed a commit that referenced this pull request Jul 16, 2017
Merge pull request #44014 from gnufied/automated-cherry-pick-of-#4297…
6a6d14c 
…3-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #42973

Cherry pick of #42973 on release-1.5.

#42973: Fix vsphere selinux support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerneltime kerneltime kerneltime approved these changes

Assignees

@kerneltime kerneltime

@eparis eparis

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet