Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #42973 #44014

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Apr 4, 2017

Cherry pick of #42973 on release-1.5.

#42973: Fix vsphere selinux support

Managed flag must be true for SELinux relabelling to work
for vsphere.
@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 4, 2017
@gnufied
Copy link
Member Author

gnufied commented May 4, 2017

@divyenpatel did you want this in 1.5 too?

@divyenpatel
Copy link
Member

Yes we need this in 1.5.
@abrarshivani @luomiao Can you please approve this PR?

@abrarshivani
Copy link
Contributor

/approve

@rootfs
Copy link
Contributor

rootfs commented May 5, 2017

/lgtm

@thockin can you approve?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abrarshivani, gnufied, rootfs
We suggest the following additional approver: thockin

Assign the PR to them by writing /assign @thockin in a comment when ready.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2017
@gnufied
Copy link
Member Author

gnufied commented May 19, 2017

@k8s-bot kubemark e2e test this

@gnufied
Copy link
Member Author

gnufied commented Jun 1, 2017

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@calebamiles calebamiles modified the milestone: v1.7 Jun 2, 2017
@gnufied
Copy link
Member Author

gnufied commented Jun 9, 2017

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@dchen1107
Copy link
Member

@calebamiles Why this marked for v1.7 milestone? Should't this belong to v1.5? I am moving this to 1.5. Please correct me if I am wrong.

@dchen1107 dchen1107 modified the milestones: v1.5, v1.7 Jun 15, 2017
@mwielgus mwielgus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jul 5, 2017
@gnufied
Copy link
Member Author

gnufied commented Jul 5, 2017

/test pull-kubernetes-e2e-kops-aws

@fejta
Copy link
Contributor

fejta commented Jul 15, 2017

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 6a6d14c into kubernetes:release-1.5 Jul 16, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet