-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix container hostPid settings #44097
Conversation
Do tests need improving to catch this? |
I think so. We should add hostnetwork/hostpid testings to node e2e tests. I will add them in a separate PR. |
would like a node e2e test before merge. |
Removing label |
@@ -306,6 +306,7 @@ func TestModifyContainerNamespaceOptions(t *testing.T) { | |||
expected: &dockercontainer.HostConfig{ | |||
NetworkMode: dockercontainer.NetworkMode(sandboxNSMode), | |||
IpcMode: dockercontainer.IpcMode(sandboxNSMode), | |||
PidMode: namespaceModeHost, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the test fail without the fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
/cc @enisoc, this fix should be included in 1.6.2. |
A node e2e test would be good. On the other hand, we do have security context tests, but they are not running anywhere in our builds: #16456 (comment) |
@yujuhong we are still rebasing on top Kubernetes 1.6, it's possible that it was not caught yet. |
:-( |
@sttts we'll need to pick this |
I manually verified the fix as well and things worked well. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, feiskyer
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue |
@feiskyer: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Automatic merge from submit-queue Automated cherry pick of kubernetes#44097 and kubernetes#44119 Cherry pick kubernetes#44097 and kubernetes#44119 for release-1.6. Fix container hostPid settings. **Release note**: ```release-note Fix container hostPid settings when CRI is enabled. ```
What this PR does / why we need it:
HostPid is not set correctly for containers.
Which issue this PR fixes
Fixes #44041.
Special notes for your reviewer:
Should be cherry-picked into v1.6 branch.
Release note:
cc @yujuhong @derekwaynecarr @unclejack @kubernetes/sig-node-pr-reviews