Add HostAliases to PodSpec to support adding entires to a Pod's hosts file #44641

evie404 · 2017-04-18T22:56:57Z

What this PR does / why we need it:
Adds a new field to PodSpec HostAliases to support adding entries to a Pod's hosts file. A PR to incorporate this logic into ensureHostsFile in kubelet will be next in order to isolate the discussion on the API.

Which issue this PR fixes:
A step into fixing #43632

Special notes for your reviewer:

The API was suggested in Provide a way to add entries to /etc/hosts #43632 (comment)
Concerns with compatible with hostNetwork: true Pods are addressed with an validation. Provide a way to add entries to /etc/hosts #43632 (comment)

Release note:

A new field `hostAliases` has been added to `pod.spec` to support adding entries to a Pod's /etc/hosts file.

Testing done:

Unit tests pass for validations
Ran all automated updates, and compared against another PR which added a field in PodSpec to make sure the PR contains all the updated generated code

k8s-reviewable · 2017-04-18T22:57:03Z

This change is

k8s-ci-robot · 2017-04-18T22:57:04Z

Hi @rickypai. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

evie404 · 2017-04-18T23:01:19Z

Btw, this should probably inherit the same labels as #43632:

area/kubelet
kind/enhancement
sig/node

evie404 · 2017-04-21T18:39:10Z

@thockin hi tim, is it possible for you to help me look at this change? it implements the proposed type for host mapping in /etc/hosts: #43632 (comment)

dims · 2017-04-24T17:29:37Z

@k8s-bot ok to test

evie404 · 2017-04-24T18:45:01Z

seems like I forgot to generate federation docs and also one of the fields do not conform to convention. updating those.

thockin

I'll approve and let the reviewer's LGTM

thockin · 2017-04-27T23:44:31Z

pkg/api/validation/validation.go

+	allErrors := field.ErrorList{}
+	if hostNetwork {
+		if len(hostMappings) > 0 {
+			allErrors = append(allErrors, field.Invalid(fldPath, hostMappings, "no `hostMappings` allowed when `hostNetwork` is true"))


field.Forbidden(..."may not be set when hostNetwork is true")

thockin · 2017-04-27T23:47:13Z

/approve

thockin · 2017-04-27T23:48:04Z

@yujuhong I'm open to better names, and if you want to discuss this more, that's fair - just hold off on the LGTM.

evie404 · 2017-04-28T02:05:04Z

Updating the name to HostAliases per discussion in #43632 (comment)

evie404 · 2017-04-29T07:14:40Z

@k8s-bot unit test this

evie404 · 2017-04-29T09:04:42Z

@k8s-bot kubemark e2e test this

thockin · 2017-04-29T16:55:19Z

/lgtm

k8s-github-robot · 2017-04-29T16:55:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rickypai, thockin

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [thockin]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-04-29T16:55:42Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2017-04-29T17:39:32Z

Automatic merge from submit-queue

@thockin

Automatic merge from submit-queue (batch tested with PRs 45110, 45148) write HostAliases to hosts file **What this PR does / why we need it**: using the PodSpec's `HostAliases`, we write entries into the Kubernetes-managed hosts file. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #43632 **Special notes for your reviewer**: Previous PRs in this series: - #44572 isolates the logic of creating the file and writing the file - #44641 introduces the `HostAliases` field in PodSpec along with validations **Release note**: ```release-note PodSpec's `HostAliases` now write entries into the Kubernetes-managed hosts file. ``` @thockin @yujuhong Thanks for reviewing!

evie404 · 2017-05-01T21:02:08Z

Thanks a lot for the fast review! There's discussion in #43632 about whether e2e is actually needed. I can write an e2e or integration test when the dust settles on which one is preferred Also, Do you think this is a valid candidate for backport to 1.6? It addresses a lot of user issues around /etc/hosts management. Thanks a lot again!

…

On Sat, Apr 29, 2017 at 10:40 AM Kubernetes Submit Queue < ***@***.***> wrote: Merged #44641 <#44641> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#44641 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZsi_jFkmDeE8rIerRFZMyWH93NmgMVks5r03XxgaJpZM4NA_uf> .

evie404 · 2017-05-01T21:03:49Z

Opps the above comment was meant for a different PR. On Mon, May 1, 2017 at 2:01 PM rickyp999@gmail.com <rickyp999@gmail.com> wrote:

…

Thanks a lot for the fast review! There's discussion in #43632 about whether e2e is actually needed. I can write an e2e or integration test when the dust settles on which one is preferred Also, Do you think this is a valid candidate for backport to 1.6? It addresses a lot of user issues around /etc/hosts management. Thanks a lot again! On Sat, Apr 29, 2017 at 10:40 AM Kubernetes Submit Queue < ***@***.***> wrote: > Merged #44641 <#44641> > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#44641 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABZsi_jFkmDeE8rIerRFZMyWH93NmgMVks5r03XxgaJpZM4NA_uf> > . >

…ias_hostnames Automatic merge from submit-queue (batch tested with PRs 46977, 47005, 47018, 47061, 46809) Fix HostAlias to validate against DNS1123 hostname instead of just labels **What this PR does / why we need it**: the validation for HostAlias was validating the hostnames against DNS labels instead of hostnames. This means hostnames like `foo.bar` would fail. I did not catch this because unit test cases only had hostnames like `foo`. **Which issue this PR fixes**: fixes issue introduced in #44641 **Release note**: ```release-note fixed HostAlias in PodSpec to allow `foo.bar` hostnames instead of just `foo` DNS labels. ```

Automatic merge from submit-queue (batch tested with PRs 42252, 42251, 42249, 47512, 47887) fix HostAliases' json keys to be hostAlias instead of hostMapping to reflect actual feature name **What this PR does / why we need it**: a rename was introduce during the middle of #44641 to change from `hostMappings` to `hostAliases`. the Go structs were updated, but I neglected to update the json keys. They should be in sync. **Special notes for your reviewer**: I messed up. This is an API change. I hope this is still ok to be in the 1.7 release. **Release note**: ```release-note HostAliases is now parsed with `hostAliases` json keys to be in line with the feature's name. ```

WanLinghao · 2017-11-23T07:48:51Z

@rickypai thanks for your well done job!
And may I ask you that file like pkg/api/v1/types.generated.go was auto-generated by what tool?
thanks a lot!

evie404 · 2017-11-24T05:00:57Z

@WanLinghao https://github.com/kubernetes/community/blob/master/contributors/devel/api_changes.md

WanLinghao · 2017-11-24T05:03:56Z

@rickypai Thanks!

k8s-github-robot assigned yujuhong and dims Apr 18, 2017

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2017

evie404 mentioned this pull request Apr 18, 2017

Provide a way to add entries to /etc/hosts #43632

Closed

evie404 force-pushed the rpai/host_mappings_type branch from 86f6494 to 32d63f3 Compare April 18, 2017 23:34

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2017

evie404 force-pushed the rpai/host_mappings_type branch 2 times, most recently from 5cf7e3f to 3be8711 Compare April 25, 2017 17:44

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2017

evie404 force-pushed the rpai/host_mappings_type branch from 3be8711 to 412f3e7 Compare April 27, 2017 18:25

k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 27, 2017

evie404 force-pushed the rpai/host_mappings_type branch from 412f3e7 to ed31db5 Compare April 27, 2017 23:08

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2017

thockin reviewed Apr 27, 2017

View reviewed changes

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2017

evie404 force-pushed the rpai/host_mappings_type branch from ed31db5 to d2cb57e Compare April 28, 2017 02:25

evie404 added 2 commits April 28, 2017 21:43

validate HostAliases have valid IP and hostnames

78d6662

generated files

a76ada8

evie404 force-pushed the rpai/host_mappings_type branch from e066bcd to a76ada8 Compare April 29, 2017 06:00

k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 29, 2017

evie404 closed this Apr 29, 2017

evie404 deleted the rpai/host_mappings_type branch April 29, 2017 07:14

evie404 restored the rpai/host_mappings_type branch April 29, 2017 07:14

evie404 reopened this Apr 29, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2017

k8s-github-robot merged commit 194a069 into kubernetes:master Apr 29, 2017

evie404 deleted the rpai/host_mappings_type branch April 29, 2017 18:31

evie404 mentioned this pull request Apr 29, 2017

write HostAliases to hosts file #45148

Merged

evie404 mentioned this pull request Jun 1, 2017

Fix HostAlias to validate against DNS1123 hostname instead of just labels #46809

Merged

evie404 mentioned this pull request Jun 14, 2017

fix HostAliases' json keys to be hostAlias instead of hostMapping to reflect actual feature name #47512

Merged

evie404 mentioned this pull request Jun 7, 2023

rlimit support #3595

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add HostAliases to PodSpec to support adding entires to a Pod's hosts file #44641

Add HostAliases to PodSpec to support adding entires to a Pod's hosts file #44641

evie404 commented Apr 18, 2017 •

edited by thockin

Loading

k8s-reviewable commented Apr 18, 2017

k8s-ci-robot commented Apr 18, 2017

evie404 commented Apr 18, 2017

evie404 commented Apr 21, 2017

dims commented Apr 24, 2017

evie404 commented Apr 24, 2017

thockin left a comment

thockin Apr 27, 2017

evie404 Apr 28, 2017

thockin commented Apr 27, 2017

thockin commented Apr 27, 2017

evie404 commented Apr 28, 2017

evie404 commented Apr 29, 2017

evie404 commented Apr 29, 2017

thockin commented Apr 29, 2017

k8s-github-robot commented Apr 29, 2017

k8s-github-robot commented Apr 29, 2017

k8s-github-robot commented Apr 29, 2017

evie404 commented May 1, 2017 via email

evie404 commented May 1, 2017 via email

WanLinghao commented Nov 23, 2017

evie404 commented Nov 24, 2017

WanLinghao commented Nov 24, 2017

Add HostAliases to PodSpec to support adding entires to a Pod's hosts file #44641

Add HostAliases to PodSpec to support adding entires to a Pod's hosts file #44641

Conversation

evie404 commented Apr 18, 2017 • edited by thockin Loading

k8s-reviewable commented Apr 18, 2017

k8s-ci-robot commented Apr 18, 2017

evie404 commented Apr 18, 2017

evie404 commented Apr 21, 2017

dims commented Apr 24, 2017

evie404 commented Apr 24, 2017

thockin left a comment

Choose a reason for hiding this comment

thockin Apr 27, 2017

Choose a reason for hiding this comment

evie404 Apr 28, 2017

Choose a reason for hiding this comment

thockin commented Apr 27, 2017

thockin commented Apr 27, 2017

evie404 commented Apr 28, 2017

evie404 commented Apr 29, 2017

evie404 commented Apr 29, 2017

thockin commented Apr 29, 2017

k8s-github-robot commented Apr 29, 2017

k8s-github-robot commented Apr 29, 2017

k8s-github-robot commented Apr 29, 2017

evie404 commented May 1, 2017 via email

evie404 commented May 1, 2017 via email

WanLinghao commented Nov 23, 2017

evie404 commented Nov 24, 2017

WanLinghao commented Nov 24, 2017

evie404 commented Apr 18, 2017 •

edited by thockin

Loading