write HostAliases to hosts file #45148

evie404 · 2017-04-29T18:36:41Z

What this PR does / why we need it: using the PodSpec's HostAliases, we write entries into the Kubernetes-managed hosts file.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #43632

Special notes for your reviewer:
Previous PRs in this series:

add tests for managed hosts file content #44572 isolates the logic of creating the file and writing the file
Add HostAliases to PodSpec to support adding entires to a Pod's hosts file #44641 introduces the HostAliases field in PodSpec along with validations

Release note:

Enable `Pod.spec.hostAliases` to add entries into the Kubernetes-managed hosts file.

@thockin @yujuhong

Thanks for reviewing!

k8s-ci-robot · 2017-04-29T18:36:48Z

Hi @rickypai. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-reviewable · 2017-04-29T18:36:49Z

This change is

evie404 · 2017-04-29T18:40:07Z

pkg/kubelet/kubelet_pods_test.go

+123.45.67.89	baz
+456.78.90.123	park
+456.78.90.123	doo
+456.78.90.123	boo


should we add validation that there are not duplicate hostnames in case someone adds:

[]v1.HostAlias{ {IP: "123.45.67.89", Hostnames: []string{"foo", "bar"}}, {IP: "456.78.90.123", Hostnames: []string{"foo", "bar"}}, }

which results in

123.45.67.89 foo 123.45.67.89 bar 456.78.90.123 foo 456.78.90.123 bar

And shouldn't we validate for proper IPv4 IPs? :-)

I think dups is fine - it's your own fault.

thockin · 2017-05-01T04:33:56Z

pkg/kubelet/kubelet_pods.go

+	// write each IP/hostname pair as an entry into hosts file
+	for _, hostAlias := range hostAliases {
+		for _, hostname := range hostAlias.Hostnames {
+			buffer.WriteString(fmt.Sprintf("%s\t%s\n", hostAlias.IP, hostname))


Comment that this was previously validated to be a valid IP address and hostname?

thockin · 2017-05-01T04:35:47Z

pkg/kubelet/kubelet_pods_test.go

+123.45.67.89	baz
+456.78.90.123	park
+456.78.90.123	doo
+456.78.90.123	boo


I think dups is fine - it's your own fault.

thockin · 2017-05-01T04:36:16Z

@k8s-bot ok to test
/approve

feiskyer · 2017-05-01T11:40:57Z

LGTM

/lgtm

k8s-github-robot · 2017-05-01T11:41:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, rickypai, thockin

Needs approval from an approver in each of these OWNERS Files:

~~pkg/kubelet/OWNERS~~ [thockin]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-05-01T11:41:32Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-ci-robot · 2017-05-01T12:13:21Z

@rickypai: The following test(s) failed:

Test name	Commit	Details	Rerun command
Jenkins unit/integration	`407fe8b`	link	`@k8s-bot unit test this`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-github-robot · 2017-05-01T12:42:15Z

Automatic merge from submit-queue (batch tested with PRs 45110, 45148)

yujuhong · 2017-05-01T16:15:44Z

@rickypai can you also add a node e2e test for this feature? Thanks.

evie404 · 2017-05-01T21:03:33Z

Thanks a lot for the fast review! There's discussion in #43632 about whether e2e is actually needed. I can write an e2e or integration test when the dust settles on which one is preferred Also, Do you think this is a valid candidate for backport to 1.6? It addresses a lot of user issues around /etc/hosts management. Thanks a lot again!

…

On Mon, May 1, 2017 at 9:16 AM Yu-Ju Hong ***@***.***> wrote: @rickypai <https://github.com/rickypai> can you also add a node e2e test for this feature? Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#45148 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABZsi5b1q6kaK1wBIJ_dtF3H_cV2jveeks5r1gVKgaJpZM4NMV9C> .

yujuhong · 2017-05-01T21:11:29Z

@rickypai, we usually patch the release branches for bugs or security issues. Your PRs added a new feature (w/ API changes), so I'd advise against back porting this.

/cc @enisoc, the 1.6 patch manager(?)
)

evie404 · 2017-05-02T17:42:44Z

No problem. I can understand the release complexity because it involves an API addition, although users won't be affected unless they actually take advantage of the new field. If they do, it's likely because they need to address #43632 #44473 or the like.

I can also just follow the build guide into doing an internal release for ourselves until 1.7 lands. I'll write a node e2e test per recommendation in #43632

thockin · 2017-06-06T18:47:48Z

@rickypai we need tomake sure we get docs for this for 1.7, too.

@kubernetes/sig-docs-maintainers

evie404 · 2017-06-07T17:42:09Z

re: documentation, i'm thinking either adding notes about HostAliases in https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/ or as a separate page under "Services, Load Balancing, and Networking"

devin-donnelly · 2017-06-07T17:46:10Z

Defer to +chenopis@google.com and +stevepe@google.com on placement.

…

On Wed, Jun 7, 2017 at 10:42 AM, Ricky Pai ***@***.***> wrote: re: documentation, i'm thinking either adding notes about HostAliases in https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/ or as a separate page under "Services, Load Balancing, and Networking" — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#45148 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARmNwM9CXirizJPSilySvSKNpT-jHMPNks5sBuEcgaJpZM4NMV9C> .

@yujuhong

Automatic merge from submit-queue (batch tested with PRs 43005, 46660, 46385, 46991, 47103) add e2e node test for Pod hostAliases feature **What this PR does / why we need it**: adds node e2e test for #45148 tests requested in #43632 (comment) **Release note**: ```release-note NONE ``` @yujuhong @thockin

evie404 · 2017-06-14T07:24:44Z

i went with a separate page to give room for more details. kubernetes/website#4080

chenopis · 2017-06-19T21:05:32Z

@rickypai That works for me.

write HostAliases to hosts file

407fe8b

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 29, 2017

k8s-github-robot assigned Random-Liu and feiskyer Apr 29, 2017

k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 29, 2017

evie404 mentioned this pull request Apr 29, 2017

Provide a way to add entries to /etc/hosts #43632

Closed

evie404 commented Apr 29, 2017

View reviewed changes

thockin reviewed May 1, 2017

View reviewed changes

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 1, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2017

k8s-github-robot merged commit 08606b5 into kubernetes:master May 1, 2017

evie404 deleted the rpai/use_host_aliases branch May 2, 2017 17:39

jstangroome mentioned this pull request May 3, 2017

/etc/hosts is overwritten despite code stating it should not be overwritten #44473

Closed

evie404 mentioned this pull request May 24, 2017

add e2e node test for Pod hostAliases feature #46385

Merged

thockin mentioned this pull request Jun 6, 2017

what should i do if i want to change container's hosts file before it start #12337

Closed

feiskyer mentioned this pull request Jun 13, 2017

自定义hosts文件 feiskyer/kubernetes-handbook#33

Closed

evie404 mentioned this pull request Jun 14, 2017

documentation for using hostAliases to manage hosts file kubernetes/website#4080

Merged

evie404 mentioned this pull request Jul 2, 2017

Kubelet should manage hosts file for HostNetwork Pods instead of Docker #48397

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

write HostAliases to hosts file #45148

write HostAliases to hosts file #45148

evie404 commented Apr 29, 2017 •

edited by thockin

Loading

k8s-ci-robot commented Apr 29, 2017

k8s-reviewable commented Apr 29, 2017

evie404 Apr 29, 2017

rantoniuk Apr 29, 2017

evie404 Apr 29, 2017

thockin May 1, 2017

thockin May 1, 2017

thockin May 1, 2017

thockin commented May 1, 2017

feiskyer commented May 1, 2017

k8s-github-robot commented May 1, 2017

k8s-github-robot commented May 1, 2017

k8s-ci-robot commented May 1, 2017 •

edited

Loading

k8s-github-robot commented May 1, 2017

yujuhong commented May 1, 2017

evie404 commented May 1, 2017 via email

yujuhong commented May 1, 2017

evie404 commented May 2, 2017

thockin commented Jun 6, 2017

evie404 commented Jun 7, 2017

devin-donnelly commented Jun 7, 2017 via email

evie404 commented Jun 14, 2017

chenopis commented Jun 19, 2017

write HostAliases to hosts file #45148

write HostAliases to hosts file #45148

Conversation

evie404 commented Apr 29, 2017 • edited by thockin Loading

k8s-ci-robot commented Apr 29, 2017

k8s-reviewable commented Apr 29, 2017

evie404 Apr 29, 2017

Choose a reason for hiding this comment

rantoniuk Apr 29, 2017

Choose a reason for hiding this comment

evie404 Apr 29, 2017

Choose a reason for hiding this comment

thockin May 1, 2017

Choose a reason for hiding this comment

thockin May 1, 2017

Choose a reason for hiding this comment

thockin May 1, 2017

Choose a reason for hiding this comment

thockin commented May 1, 2017

feiskyer commented May 1, 2017

k8s-github-robot commented May 1, 2017

k8s-github-robot commented May 1, 2017

k8s-ci-robot commented May 1, 2017 • edited Loading

k8s-github-robot commented May 1, 2017

yujuhong commented May 1, 2017

evie404 commented May 1, 2017 via email

yujuhong commented May 1, 2017

evie404 commented May 2, 2017

thockin commented Jun 6, 2017

evie404 commented Jun 7, 2017

devin-donnelly commented Jun 7, 2017 via email

evie404 commented Jun 14, 2017

chenopis commented Jun 19, 2017

evie404 commented Apr 29, 2017 •

edited by thockin

Loading

k8s-ci-robot commented May 1, 2017 •

edited

Loading