Increase Dashboard memory limits #44712
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/XS
|
CC @kubernetes/dashboard-maintainers |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm, zmerlynn
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 43884, 44712, 45124, 43883) |
| @@ -25,10 +25,10 @@ spec: | |||
| # keep request = limit to keep this container in guaranteed class | |||
There was a problem hiding this comment.
Now that memory request and limit are different, that comment is probably wrong.
There was a problem hiding this comment.
Yes, you are right. Should I fix it or you will take care of it?
There was a problem hiding this comment.
Well, it depends on what is desired: either we fix the comment or the limits to restore the truth.
I believe the latter is the best option to get the Guaranteed QoS on that pod:
If limits and optionally requests (not equal to 0) are set for all resources across all containers and they are equal, then the pod is classified as Guaranteed.
What this PR does / why we need it: Increases memory requests and limits for Dashboard.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes kubernetes/dashboard#1431Special notes for your reviewer: Dashboard crashes on large clusters, this change should fix that problem.
Release note: