Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Dashboard memory limits #44712

Merged
merged 1 commit into from
May 1, 2017
Merged

Increase Dashboard memory limits #44712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions cluster/addons/dashboard/dashboard-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ spec:
# keep request = limit to keep this container in guaranteed class
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that memory request and limit are different, that comment is probably wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. Should I fix it or you will take care of it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it depends on what is desired: either we fix the comment or the limits to restore the truth.

I believe the latter is the best option to get the Guaranteed QoS on that pod:

If limits and optionally requests (not equal to 0) are set for all resources across all containers and they are equal, then the pod is classified as Guaranteed.

https://github.com/kubernetes/community/blob/master/contributors/design-proposals/resource-qos.md#qos-classes

limits:
cpu: 100m
memory: 50Mi
memory: 300Mi
requests:
cpu: 100m
memory: 50Mi
memory: 100Mi
ports:
- containerPort: 9090
livenessProbe:
Expand Down