Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #44570 #44862 #44877

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Apr 24, 2017

Cherry pick of #44570 #44862 on release-1.6.

#44570: Explicit namespace from kubeconfig should override in-cluster
#44862: Stop treating in-cluster-config namespace as an override

* kubectl commands run inside a pod using a kubeconfig file now use the namespace specified in the kubeconfig file, instead of using the pod namespace. If no kubeconfig file is used, or the kubeconfig does not specify a namespace, the pod namespace is still used as a fallback.
* Restored the ability of kubectl running inside a pod to consume resource files specifying a different namespace than the one the pod is running in.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Apr 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2017
@enisoc
Copy link
Member

enisoc commented Apr 24, 2017

LGTM once all parent PRs merge.

@liggitt liggitt assigned smarterclayton and unassigned sttts and bprashanth Apr 25, 2017
@liggitt
Copy link
Member Author

liggitt commented Apr 25, 2017

parents are merged. @smarterclayton for lgtm

@smarterclayton
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Apr 25, 2017
@liggitt
Copy link
Member Author

liggitt commented Apr 25, 2017

tagging per #44877 (comment)

@liggitt liggitt added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Apr 25, 2017
@enisoc enisoc added this to the v1.6 milestone Apr 25, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit da7146d into kubernetes:release-1.6 Apr 25, 2017
@jimmycuadra
Copy link
Contributor

Was this included in 1.6.2? If not, do we have an ETA on a 1.6.3 release? Our custom deployment automation is completely broken by this. We had been continuing to use kubectl 1.4.x as a workaround (see #43662) while our cluster was running 1.5.x, but after upgrading to 1.6.2, kubectl 1.4.x no longer works and we were forced to upgrade it. kubectl 1.4 produces this error when used to apply resources to a 1.6 cluster:

error: group map[componentconfig:0xc8203ad420 rbac.authorization.k8s.io:0xc8204d0000 certificates.k8s.io:0xc8203ad3b0 :0xc8203acee0 apps:0xc8203acf50 authentication.k8s.io:0xc8203acfc0 authorization.k8s.io:0xc8203ad110 autoscaling:0xc8203ad180 batch:0xc8203ad340 extensions:0xc8203ad500 federation:0xc8203aca10 storage.k8s.io:0xc82010a000 policy:0xc8203ad570] is already registered

@enisoc
Copy link
Member

enisoc commented May 8, 2017

@jimmycuadra This will be included in v1.6.3, which I plan to cut sometime this week.

@liggitt liggitt deleted the automated-cherry-pick-of-#44570-#44862-upstream-release-1.6 branch February 15, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants