Display extended resources in node allocated resources #46079

xiangpengzhao · 2017-05-19T06:27:10Z

What this PR does / why we need it:
Displays ~~opaque integer~~ [extended] resources in node allocated resources of command kubectl describe node. This will give users more info about node ~~OIR~~ [extended resources] consumption.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
This is a partially fix of #44271.

Special notes for your reviewer:
This PR

only displays allocated ~~OIR~~ [extended resources] details of node, it doesn't display ~~OIR~~ [extended resources] requests/limits for each pod because it's hard to organize format. I tried to print ~~OIR~~ [extended resources] requests/limits of pods, but some strings have been eaten when a line is too long (the output has been separated into two lines by terminal). I think it's because a \t blank can't be show in two lines.
~~uses OIR-foo instead of pod.alpha.kubernetes.io/opaque-int-resource-foo for short.~~
doesn't display the percentage of ~~OIR~~ [extended resources] usage because I think the percentage is not so meaningful.
displays each ~~OIR~~ [extended resources] in single rows to be clear.

UPDATE:
Example with default namespace resource:

Non-terminated Pods:         (1 in total)
  Namespace                  Name                     CPU Requests  CPU Limits  Memory Requests  Memory Limits
  ---------                  ----                     ------------  ----------  ---------------  -------------
  default                    rc-nginx-single-krp84    1 (33%)       1 (33%)     512Mi (6%)       512Mi (6%)
Allocated resources:
  (Total limits may be over 100 percent, i.e., overcommitted.)
Resource                 Requests    Limits
  --------               --------    ------
  cpu                    1 (33%)     1 (33%)
  memory                 512Mi (6%)  512Mi (6%)
  kubernetes.io/widgets  111         0

/cc @ConnorDoyle @soltysh

ref #44181

Release note:

Display requests/limits of extended resources in node allocated resources.

xiangpengzhao · 2017-05-19T06:28:11Z

/assign @ConnorDoyle @soltysh

spiffxp · 2017-07-10T22:16:19Z

/ok-to-test

pwittrock · 2017-07-31T20:44:07Z

/unassign

pwittrock · 2017-07-31T20:44:43Z

/assign @Random-Liu

pwittrock · 2017-07-31T20:44:50Z

/assign @dchen1107

pwittrock · 2017-07-31T20:45:17Z

@xiangpengzhao Please add a release note

xiangpengzhao · 2017-08-01T01:50:36Z

Editing release note in PR body didn't take effect. Add it manually here.

Display requests/limits of opaque integer resources in node allocated resources.

xiangpengzhao · 2017-08-01T01:51:46Z

Release note:

Display requests/limits of opaque integer resources in node allocated resources.

xiangpengzhao · 2017-08-01T01:55:01Z

Hmm, none of the ways I tried to add release note works...

@spxtr How can I add a release note in this case? Thanks!

I remember I saw some guy adding release note like this way: #46079 (comment) above.

xiangpengzhao · 2017-08-01T02:07:44Z

/release-note

hope this works :)

soltysh · 2017-08-08T14:24:25Z

The change itself looks good, but I'm not sure if this isn't breaking api, since we're adding quite a few additional information. @kubernetes/sig-cli-api-reviews wdyt should we keep that additional data behind a flag or something?

dixudx · 2018-02-12T02:38:26Z

/lgtm

spiffxp · 2018-02-16T00:35:22Z

/unassign

RenaudWasTaken · 2018-02-24T01:21:00Z

Can we get this in for 1.10 cc @vishh @smarterclayton ?

jiayingz · 2018-03-27T00:50:25Z

/cc @jiayingz

ConnorDoyle · 2018-03-27T04:31:50Z

Every now and then I get notifications from this PR and feel a great sadness.

xiangpengzhao · 2018-03-27T04:44:51Z

@ConnorDoyle haha... The PR is 🔟 months old. 👶 --> 👴

ping some folks from approvers list: @adohe @smarterclayton @liggitt @mengqiy @deads2k @brendandburns @janetkuo :)

liggitt · 2018-03-27T04:53:19Z

pkg/printers/internalversion/describe.go

-	w.Write(LEVEL_0, "Allocated resources:\n  (Total limits may be over 100 percent, i.e., overcommitted.)\n  CPU Requests\tCPU Limits\tMemory Requests\tMemory Limits\n")
-	w.Write(LEVEL_1, "------------\t----------\t---------------\t-------------\n")
+	w.Write(LEVEL_0, "Allocated resources:\n  (Total limits may be over 100 percent, i.e., overcommitted.)\n")
+	w.Write(LEVEL_0, "Resource\tRequests\tLimits\n")


should be LEVEL_1 to get Resource to align with --------, right?

Good catch! A big 👍 for you :)

xiangpengzhao · 2018-03-28T02:19:54Z

@liggitt inline comment addressed. PTAL. Thanks!

liggitt · 2018-03-28T02:23:32Z

/lgtm

k8s-ci-robot · 2018-03-28T02:23:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorDoyle, dixudx, liggitt, soltysh, spiffxp, vishh, xiangpengzhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/printers/OWNERS~~ [liggitt,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

xiangpengzhao · 2018-03-28T02:58:04Z

/retest

fejta-bot · 2018-03-28T05:35:53Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-03-28T08:02:53Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

fejta-bot · 2018-03-28T10:29:52Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

k8s-github-robot · 2018-03-28T11:04:48Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2018-03-28T11:57:50Z

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

ConnorDoyle · 2018-03-28T14:40:51Z

🙏🏽 @liggitt !

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 19, 2017

k8s-ci-robot requested review from ConnorDoyle and soltysh May 19, 2017 06:27

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2017

k8s-github-robot assigned ericchiang and ghodss May 19, 2017

k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels May 19, 2017

k8s-ci-robot assigned ConnorDoyle and soltysh and unassigned ericchiang and ghodss May 19, 2017

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2017

k8s-ci-robot assigned pwittrock Jul 25, 2017

k8s-ci-robot unassigned pwittrock Jul 31, 2017

k8s-ci-robot assigned Random-Liu Jul 31, 2017

xiangpengzhao mentioned this pull request Aug 1, 2017

k8s-merge-robot labels PR "release-note" even when the release note is "NONE" kubernetes/test-infra#3295

Closed

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 1, 2017

k8s-ci-robot assigned dixudx Feb 12, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2018

k8s-ci-robot unassigned spiffxp Feb 16, 2018

k8s-ci-robot requested a review from jiayingz March 27, 2018 00:50

liggitt reviewed Mar 27, 2018

View reviewed changes

xiangpengzhao force-pushed the print-allocated-oir branch from 64b9c4d to bd02b49 Compare March 28, 2018 02:18

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 28, 2018

Display extended resources in node allocated resources

bd02b49

k8s-ci-robot assigned liggitt Mar 28, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2018

k8s-github-robot merged commit 33482dd into kubernetes:master Mar 28, 2018

xiangpengzhao deleted the print-allocated-oir branch March 28, 2018 14:17

clkao mentioned this pull request Jul 11, 2018

Kubectl doesn't print GPU allocated when using kubectl describe node xxxx #57094

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display extended resources in node allocated resources #46079

Display extended resources in node allocated resources #46079

xiangpengzhao commented May 19, 2017 •

edited

Loading

xiangpengzhao commented May 19, 2017

spiffxp commented Jul 10, 2017

pwittrock commented Jul 31, 2017

pwittrock commented Jul 31, 2017

pwittrock commented Jul 31, 2017

pwittrock commented Jul 31, 2017

xiangpengzhao commented Aug 1, 2017

xiangpengzhao commented Aug 1, 2017

xiangpengzhao commented Aug 1, 2017

xiangpengzhao commented Aug 1, 2017

soltysh commented Aug 8, 2017

dixudx commented Feb 12, 2018

spiffxp commented Feb 16, 2018

RenaudWasTaken commented Feb 24, 2018

jiayingz commented Mar 27, 2018

ConnorDoyle commented Mar 27, 2018

xiangpengzhao commented Mar 27, 2018

liggitt Mar 27, 2018

xiangpengzhao Mar 28, 2018

xiangpengzhao commented Mar 28, 2018

liggitt commented Mar 28, 2018

k8s-ci-robot commented Mar 28, 2018

xiangpengzhao commented Mar 28, 2018

fejta-bot commented Mar 28, 2018

fejta-bot commented Mar 28, 2018

fejta-bot commented Mar 28, 2018

k8s-github-robot commented Mar 28, 2018

k8s-github-robot commented Mar 28, 2018

ConnorDoyle commented Mar 28, 2018

Display extended resources in node allocated resources #46079

Display extended resources in node allocated resources #46079

Conversation

xiangpengzhao commented May 19, 2017 • edited Loading

xiangpengzhao commented May 19, 2017

spiffxp commented Jul 10, 2017

pwittrock commented Jul 31, 2017

pwittrock commented Jul 31, 2017

pwittrock commented Jul 31, 2017

pwittrock commented Jul 31, 2017

xiangpengzhao commented Aug 1, 2017

xiangpengzhao commented Aug 1, 2017

xiangpengzhao commented Aug 1, 2017

xiangpengzhao commented Aug 1, 2017

soltysh commented Aug 8, 2017

dixudx commented Feb 12, 2018

spiffxp commented Feb 16, 2018

RenaudWasTaken commented Feb 24, 2018

jiayingz commented Mar 27, 2018

ConnorDoyle commented Mar 27, 2018

xiangpengzhao commented Mar 27, 2018

liggitt Mar 27, 2018

Choose a reason for hiding this comment

xiangpengzhao Mar 28, 2018

Choose a reason for hiding this comment

xiangpengzhao commented Mar 28, 2018

liggitt commented Mar 28, 2018

k8s-ci-robot commented Mar 28, 2018

xiangpengzhao commented Mar 28, 2018

fejta-bot commented Mar 28, 2018

fejta-bot commented Mar 28, 2018

fejta-bot commented Mar 28, 2018

k8s-github-robot commented Mar 28, 2018

k8s-github-robot commented Mar 28, 2018

ConnorDoyle commented Mar 28, 2018

xiangpengzhao commented May 19, 2017 •

edited

Loading