Extract proxy/config common functions for reuse #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Merge(source string, update interface{}) error | ||
| } | ||
|
|
||
| // MergeFunc is a function that can be used to merge in a Mux |
There was a problem hiding this comment.
Add ". Implements the Merger interface."
|
I'm still wrapping my head around this. I'll finish reading it later today. |
|
comments addressed |
| configSourceLock sync.RWMutex | ||
| serviceConfigSources map[string]chan ServiceUpdate | ||
| endpointsConfigSources map[string]chan EndpointsUpdate | ||
| // NewEndpointConfig creates a new EndpointConfig. |
There was a problem hiding this comment.
move this comment down to the NewEndpointsConfig?
|
Small stuff, basically LGTM, modulo using defer ... for all of the unlocks. |
|
LGTM. @lavalamp want to take one last look? |
|
On it, ETA ~hours |
|
|
||
| // Accessor is an interface for retrieving the current merge state. | ||
| type Accessor interface { | ||
| // MergedSTate returns a representation of the current merge state. |
There was a problem hiding this comment.
Nit: Typo s/MergedSTate/MergedState/
Extracted from proxy/config
Splits endpoint and service configuration into their own objects. Also makes the endpoint and service configuration tests correct - there was a race condition previously that meant tests were passing but not checking correct code.
|
LGTM |
smarterclayton
added a commit
that referenced
this pull request
Jul 16, 2014
Extract proxy/config common functions for reuse
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
docs: broken relative link fixes
keontang
pushed a commit
to keontang/kubernetes
that referenced
this pull request
May 14, 2016
Fix delete lb bug
keontang
pushed a commit
to keontang/kubernetes
that referenced
this pull request
Jul 1, 2016
Fix delete lb bug
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Dec 8, 2016
Fix delete lb bug
mqliang
pushed a commit
to mqliang/kubernetes
that referenced
this pull request
Mar 3, 2017
Fix delete lb bug
sjenning
pushed a commit
to sjenning/kubernetes
that referenced
this pull request
Dec 2, 2020
…rry-pick-462-to-release-4.6 [release-4.6] Bug 1899406: HPA: Ignore deleted pods.
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 4, 2021
Cherry pick #465 in cloud provider azure to 1.18: Cleanup subnet in frontend IP configs
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 4, 2021
Cherry pick #465 in cloud provider azure to 1.20: Cleanup subnet in frontend IP configs
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 4, 2021
Cherry pick #465 in cloud provider azure to 1.19: Cleanup subnet in frontend IP configs
b3atlesfan
pushed a commit
to b3atlesfan/kubernetes
that referenced
this pull request
Feb 5, 2021
Support quorum read option
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 18, 2021
Cherry pick #465 in cloud provider azure: Cleanup subnet in frontend IP configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor proxy to use the common config. This is a prereq for #356 and the commits
have had feedback from @thockin only.
Also fix tests.