Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant carriage return for readable #46562

Merged

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented May 27, 2017

What this PR does / why we need it:

remove redundant carriage to make it more readable.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 27, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels May 27, 2017
@cblecker
Copy link
Member

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 28, 2017
@dixudx
Copy link
Member Author

dixudx commented May 29, 2017

@cblecker pls label LGTM. Thx.

@dixudx
Copy link
Member Author

dixudx commented May 30, 2017

The failed pull-kubernetes-unit test seems unrelated to this PR.

@cblecker
Copy link
Member

@k8s-bot pull-kubernetes-unit test this

@dixudx
Copy link
Member Author

dixudx commented May 31, 2017

@cblecker Waiting for your LGTM and release note label. Thanks.

@cblecker
Copy link
Member

/lgtm
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 31, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2017
@dixudx
Copy link
Member Author

dixudx commented May 31, 2017

/assign @thockin

@thockin
Copy link
Member

thockin commented May 31, 2017

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dixudx, thockin

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46661, 46562, 46657, 46655, 46640)

@k8s-github-robot k8s-github-robot merged commit 50c6a38 into kubernetes:master May 31, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 31, 2017

@dixudx: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e caeb584 link @k8s-bot pull-kubernetes-node-e2e test this
pull-kubernetes-unit caeb584 link @k8s-bot pull-kubernetes-unit test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dixudx dixudx deleted the volume_manager_function_format branch September 9, 2017 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants