-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kube-proxy cleanups #46716
Kube-proxy cleanups #46716
Conversation
@MrHohn do we have real docs on traffic policy? |
No yet, all existing docs is about beta annotations. I will be soon working on updating those docs to reflect the new fields. |
LGTM, please run below scripts :)
|
/lgtm |
9e5e6ec
to
0838ad4
Compare
re-pushed, self-lgtm |
pull-verify job is still complaining :)
|
@k8s-bot pull-kubernetes-federation-e2e-gce test this /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, thockin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
1 similar comment
@k8s-bot pull-kubernetes-federation-e2e-gce test this |
This is weird, validation.go is already updated to use "Cluster" instead of "Global" in PR, but from the test failures we could still see "Global" is inused:
Triggering test again to verify. @k8s-bot pull-kubernetes-federation-e2e-gce test this |
@MrHohn, maybe the already deployed k8s clusters are not updated with the change you are mentioning. probably will be fixed after federation k8s clusters are recycled. |
@thockin: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@shashidharatd Thanks, I see the problem now. The changes I mentioned are made in this PR, so they will never be deployed to federation clusters for testing if this PR is not in yet... |
Wouldn't this model (existing clusters v.s. updated federation server) block all this kind of changes? |
Yes that's a problem we need to address. cc @madhusudancs, @csbell |
@MrHohn @shashidharatd federation presubmits won't be made non-blocking for now. We need to figure out what to do for PRs like this. Let me think. I am fine manually merging this PR for now. |
OK, I will manually merge this. |
@thockin thanks! |
Add comments.
Clarify flag help.
Rename ExternalTrafficPolicy from "Global" to "Cluster", to not imply federation tie-ins.
Release Note: