Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete the controller context for init funcs #46783

Merged
merged 1 commit into from
Jun 4, 2017
Merged

complete the controller context for init funcs #46783

merged 1 commit into from
Jun 4, 2017
+220 −192

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 1, 2017

This completes the conversion to initFuncs for the controller initialization to make easier and more manageable to add them.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Jun 1, 2017
liggitt
liggitt reviewed Jun 1, 2017
View reviewed changes
cmd/kube-controller-manager/app/controllermanager.go Outdated
@@ -274,11 +281,6 @@ func KnownControllers() []string {

ret.Insert(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the comment about special controllers here, and give guidance if people should not generally add anything else to this list

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@deads2k deads2k force-pushed the controller-08-initfn branch 2 times, most recently from 5056b80 to fd38632 Compare June 1, 2017 17:38
@deads2k deads2k added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 1, 2017
@deads2k deads2k added this to the v1.7 milestone Jun 1, 2017
liggitt
liggitt reviewed Jun 1, 2017
View reviewed changes
cmd/kube-controller-manager/app/controllermanager.go

sharedInformers.Start(stop)
// start the first set of informers now so that other controllers can start
ctx.InformerFactory.Start(ctx.Stop)
Copy link
Member

@liggitt liggitt Jun 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it odd to tie sharedInformers to this controller? if you don't provide a private key and this never starts, doesn't it block other controllers? if you're not running with --use-service-account-credentials, what else in the controller manager depends on this controller?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it odd to tie sharedInformers to this controller?

Not really, this is the logical order from before, it's just slightly more obvious

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what else in the controller manager depends on this controller?

Not completely certain. I think the future is subdivision.

@liggitt
Copy link
Member

liggitt commented Jun 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2017
@deads2k deads2k added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 2, 2017
@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Jun 2, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@deads2k
Copy link
Contributor Author

deads2k commented Jun 2, 2017

Queue is confused. Etcd3 passed

@liggitt
Copy link
Member

liggitt commented Jun 2, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Jun 2, 2017 

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@fejta
Copy link
Contributor

fejta commented Jun 2, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this
ref: #46827

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 40760, 46706, 46783, 46742, 46751)

@k8s-github-robot k8s-github-robot merged commit 638c738 into kubernetes:master Jun 4, 2017
@deads2k deads2k deleted the controller-08-initfn branch August 3, 2017 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deads2k @liggitt @k8s-github-robot @fejta @k8s-ci-robot