Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to MaxInt32 #46795

Closed
wants to merge 1 commit into from
Closed

Change to MaxInt32 #46795

wants to merge 1 commit into from

Conversation

caesarxuchao
Copy link
Member

Fixing #46793

InclusiveRange takes int as input parameter, passing math.MaxUint32 overflows int on a 32-bit platform.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2017
@caesarxuchao caesarxuchao added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 1, 2017
@caesarxuchao
Copy link
Member Author

It's blocking cutting 1.7.0-beta.0, so marked as critical.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 1, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2017
@caesarxuchao
Copy link
Member Author

cc @dchen1107

@dchen1107
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, dchen1107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Jun 1, 2017
@luxas luxas added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Jun 1, 2017
@luxas
Copy link
Member

luxas commented Jun 1, 2017

This is a dupe of #46711, right?

@caesarxuchao
Copy link
Member Author

Yeah, closing.

@dchen1107
Copy link
Member

@luxas, Thanks for updates.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 1, 2017 •
edited

@caesarxuchao: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-unit be96340 link @k8s-bot pull-kubernetes-unit test this
pull-kubernetes-federation-e2e-gce be96340 link @k8s-bot pull-kubernetes-federation-e2e-gce test this
pull-kubernetes-bazel be96340 link @k8s-bot pull-kubernetes-bazel test this
pull-kubernetes-e2e-kops-aws be96340 link @k8s-bot pull-kubernetes-e2e-kops-aws test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@caesarxuchao @dchen1107 @k8s-github-robot @luxas @k8s-ci-robot @derekwaynecarr