Add an e2e test for server side get #46881
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package(default_visibility = ["//visibility:public"]) | ||
|
|
||
| licenses(["notice"]) | ||
|
|
||
| load( | ||
| "@io_bazel_rules_go//go:def.bzl", | ||
| "go_library", | ||
| ) | ||
|
|
||
| go_library( | ||
| name = "go_default_library", | ||
| srcs = ["table_conversion.go"], | ||
| tags = ["automanaged"], | ||
| deps = [ | ||
| "//pkg/api/v1:go_default_library", | ||
| "//pkg/printers:go_default_library", | ||
| "//test/e2e/framework:go_default_library", | ||
| "//vendor/github.com/onsi/ginkgo:go_default_library", | ||
| "//vendor/github.com/onsi/gomega:go_default_library", | ||
| "//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library", | ||
| "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", | ||
| "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1alpha1:go_default_library", | ||
| ], | ||
| ) | ||
|
|
||
| filegroup( | ||
| name = "package-srcs", | ||
| srcs = glob(["**"]), | ||
| tags = ["automanaged"], | ||
| visibility = ["//visibility:private"], | ||
| ) | ||
|
|
||
| filegroup( | ||
| name = "all-srcs", | ||
| srcs = [":package-srcs"], | ||
| tags = ["automanaged"], | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| /* | ||
| Copyright 2017 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package extension | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "fmt" | ||
| "text/tabwriter" | ||
|
|
||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
|
|
||
| "k8s.io/apimachinery/pkg/api/errors" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| metav1alpha1 "k8s.io/apimachinery/pkg/apis/meta/v1alpha1" | ||
| "k8s.io/kubernetes/pkg/api/v1" | ||
| "k8s.io/kubernetes/pkg/printers" | ||
| "k8s.io/kubernetes/test/e2e/framework" | ||
| ) | ||
|
|
||
| var _ = framework.KubeDescribe("Servers with support for Table transformation", func() { | ||
| f := framework.NewDefaultFramework("tables") | ||
|
|
||
| It("should return pod details", func() { | ||
| ns := f.Namespace.Name | ||
| c := f.ClientSet | ||
|
|
||
| podName := "pod-1" | ||
| framework.Logf("Creating pod %s", podName) | ||
|
|
||
| _, err := c.Core().Pods(ns).Create(newPod(podName)) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| table := &metav1alpha1.Table{} | ||
| err = c.Core().RESTClient().Get().Resource("pods").Namespace(ns).Name(podName).SetHeader("Accept", "application/json;as=Table;v=v1alpha1;g=meta.k8s.io").Do().Into(table) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| framework.Logf("Table: %#v", table) | ||
|
|
||
| Expect(len(table.ColumnDefinitions)).To(BeNumerically(">", 2)) | ||
| Expect(len(table.Rows)).To(Equal(1)) | ||
| Expect(len(table.Rows[0].Cells)).To(Equal(len(table.ColumnDefinitions))) | ||
| Expect(table.ColumnDefinitions[0].Name).To(Equal("Name")) | ||
| Expect(table.Rows[0].Cells[0]).To(Equal(podName)) | ||
|
|
||
| out := printTable(table) | ||
| Expect(out).To(MatchRegexp("^NAME\\s")) | ||
| Expect(out).To(MatchRegexp("\npod-1\\s")) | ||
| framework.Logf("Table:\n%s", out) | ||
| }) | ||
|
|
||
| It("should return generic metadata details across all namespaces for nodes", func() { | ||
| c := f.ClientSet | ||
|
|
||
| table := &metav1alpha1.Table{} | ||
| err := c.Core().RESTClient().Get().Resource("nodes").SetHeader("Accept", "application/json;as=Table;v=v1alpha1;g=meta.k8s.io").Do().Into(table) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| framework.Logf("Table: %#v", table) | ||
|
|
||
| Expect(len(table.ColumnDefinitions)).To(BeNumerically(">=", 2)) | ||
| Expect(len(table.Rows)).To(BeNumerically(">=", 1)) | ||
| Expect(len(table.Rows[0].Cells)).To(Equal(len(table.ColumnDefinitions))) | ||
| Expect(table.ColumnDefinitions[0].Name).To(Equal("Name")) | ||
|
|
||
| out := printTable(table) | ||
| Expect(out).To(MatchRegexp("^NAME\\s")) | ||
| framework.Logf("Table:\n%s", out) | ||
| }) | ||
|
|
||
| It("should return a 406 for a backend which does not implement metadata", func() { | ||
| c := f.ClientSet | ||
|
|
||
| table := &metav1alpha1.Table{} | ||
| err := c.Core().RESTClient().Get().Resource("services").SetHeader("Accept", "application/json;as=Table;v=v1alpha1;g=meta.k8s.io").Do().Into(table) | ||
| Expect(err).To(HaveOccurred()) | ||
| Expect(err.(errors.APIStatus).Status().Code).To(Equal(int32(406))) | ||
| }) | ||
| }) | ||
|
|
||
| func printTable(table *metav1alpha1.Table) string { | ||
| buf := &bytes.Buffer{} | ||
| tw := tabwriter.NewWriter(buf, 5, 8, 1, ' ', 0) | ||
| err := printers.PrintTable(table, tw, printers.PrintOptions{}) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| tw.Flush() | ||
| return buf.String() | ||
| } | ||
|
|
||
| func newPod(podName string) *v1.Pod { | ||
| containerName := fmt.Sprintf("%s-container", podName) | ||
| port := 8080 | ||
| pod := &v1.Pod{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: podName, | ||
| }, | ||
| Spec: v1.PodSpec{ | ||
| Containers: []v1.Container{ | ||
| { | ||
| Name: containerName, | ||
| Image: "gcr.io/google_containers/porter:4524579c0eb935c056c8e75563b4e1eda31587e0", | ||
| Env: []v1.EnvVar{{Name: fmt.Sprintf("SERVE_PORT_%d", port), Value: "foo"}}, | ||
| Ports: []v1.ContainerPort{{ContainerPort: int32(port)}}, | ||
| }, | ||
| }, | ||
| RestartPolicy: v1.RestartPolicyNever, | ||
| }, | ||
| } | ||
| return pod | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we no longer defaulting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a panic or something here so that people who aren't using the generic store will get at least some notification that things won't work right. Method supports an error, so use that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're allowed not to support server side get - this change returns a 406 if that happens. This ensures that swagger matches what the storage supports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm.. We'll want some sort of verify or we'll get weird problems eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be a followup in 1.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a verify in the e2e test