Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iscsi storage plugin: bkpPortal should be initialized beforehand #46968

Merged
merged 1 commit into from
Jun 6, 2017
Merged

iscsi storage plugin: bkpPortal should be initialized beforehand #46968

merged 1 commit into from
Jun 6, 2017

Conversation

mtanino
Copy link

@mtanino mtanino commented Jun 5, 2017

What this PR does / why we need it:
This patch is a follow up patch for the PR #46239.
The bkpPortal in DetachDisk() path should be initialized before using it.

Special notes for your reviewer:
/cc @rootfs @childsb

Release note:

NONE

bkpPortal should be initialized beforehand
82ce37d 
This patch is a follow up patch for the PR#46239.
The bkpPortal in DetachDisk() path should be initialized
before using it.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @mtanino. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 5, 2017
@rootfs
Copy link
Contributor

rootfs commented Jun 5, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 5, 2017
@rootfs
Copy link
Contributor

rootfs commented Jun 5, 2017

/assign

@mtanino
Copy link
Author

mtanino commented Jun 5, 2017

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@rootfs
Copy link
Contributor

rootfs commented Jun 5, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtanino, rootfs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2017
@eparis
Copy link
Contributor

eparis commented Jun 5, 2017

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@eparis eparis added this to the v1.7 milestone Jun 5, 2017
@eparis
Copy link
Contributor

eparis commented Jun 5, 2017

Its a bug fix, assigning to 1.7

@mtanino
Copy link
Author

mtanino commented Jun 5, 2017

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@mtanino
Copy link
Author

mtanino commented Jun 5, 2017

/retest

1 similar comment
@mtanino
Copy link
Author

mtanino commented Jun 6, 2017

/retest

@mtanino mtanino mentioned this pull request Jun 6, 2017
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46112, 46764, 46727, 46974, 46968)

@k8s-github-robot k8s-github-robot merged commit 475e479 into kubernetes:master Jun 6, 2017
k8s-github-robot pushed a commit that referenced this pull request Jun 9, 2017
Merge pull request #46912 from mtanino/automated-cherry-pick-of-#4623…
cca1964 
…9-upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #46239

Cherry pick of #46239 on release-1.6.

#46239: Log out from multiple portals with iscsi storage plugin

This Cherry pick also includes fix #46968(follow-up fix for #46239)

#46968: iscsi storage plugin: bkpPortal should be initialized beforehand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childsb childsb Awaiting requested review from childsb

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@smarterclayton smarterclayton

@jsafrane jsafrane

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mtanino @k8s-ci-robot @rootfs @k8s-github-robot @eparis @smarterclayton @jsafrane