New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore 404s on evict #47450
Ignore 404s on evict #47450
Conversation
/release-note-none |
/lgtm |
@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this |
/assign @fabianofranz |
Opened #47608 for the fake discovery client stuff. |
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, fabianofranz, kargakis Associated issue: 28 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest |
2 similar comments
/retest |
/retest |
Automatic merge from submit-queue (batch tested with PRs 47523, 47438, 47550, 47450, 47612) |
In kubernetes#47450 we stopped returning an error if a pod disappeared before we could remove it. Instead we just continue to spin forever. Return "success" if a pod disappeared before we actually removed it. https://bugzilla.redhat.com/1473777 bug 1473777
In kubernetes#47450 we stopped returning an error if a pod disappeared before we could remove it. Instead we just continue to spin forever. Return "success" if a pod disappeared before we actually removed it. https://bugzilla.redhat.com/1473777 bug 1473777
Automatic merge from submit-queue (batch tested with PRs 49444, 47864, 48584, 49395, 49118) Do not spin forever if kubectl drain races with other removal In #47450 we stopped returning an error if a pod disappeared before we could remove it. Instead we just continue to spin forever. Return "success" if a pod disappeared before we actually removed it. https://bugzilla.redhat.com/1473777 bug 1473777 ```release-note `kubectl drain` no longer spins trying to delete pods that do not exist ```
One of our upgrades failed with
@derekwaynecarr since you already fixed half of it
cc: @kubernetes/sig-cli-bugs
I failed terribly at adding a unit test mostly because draining involves discovery for the eviction API and the fake client stuff for discovery are far from functional - will spawn a separate issue about it.
fyi @jupierce
related: kubernetes/kubectl#28