Revert "Ignore daemonset-controller-hash label key in federation before comparing the federated object with its cluster equivalent."
#47473
+0
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore comparing the federated object with its cluster equivalent." This reverts commit 3530c9c.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/S
|
/retest |
k8s-github-robot
added
the
approved
|
#47258 was merged |
|
@janetkuo let's wait until midnight for clusters to recycle. |
|
/retest |
|
/retest failure seems unrelated |
|
federation is broken: #46827, waiting on cluster recycle |
|
/retest |
1 similar comment
|
/retest |
|
@madhusudancs now it finally passed! |
|
@janetkuo awesome! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: janetkuo, madhusudancs Associated issue: 47258 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 47451, 47410, 47598, 47616, 47473) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3530c9c.
This needs to wait for #47258, otherwise federation test won't pass(merged)Release note: