Turn off the alpha features by default

[caesarxuchao]

Fix #47687.

@liggitt @sttts do you know if it's intentional to turn on rbac v1alpha1?

The following alpha API groups were unintentionally enabled by default in previous releases, and will no longer be enabled by default in v1.8:
rbac.authorization.k8s.io/v1alpha1
settings.k8s.io/v1alpha1
If you wish to continue using them in v1.8, please enable them explicitly using the `--runtime-config` flag of the apiserver (for example, `--runtime-config="rbac.authorization.k8s.io/v1alpha1,settings.k8s.io/v1alpha1"`)

[liggitt]

don't turn this off... it's been on since 1.5 and we need to ensure we can read existing data. new data is written in v1beta1 as of 1.6

[liggitt]

actually, I just tried launching with v1alpha1 data in etcd with this PR (which leaves v1alpha1 registered, but disabled by default), and the data was able to be read out of etcd just fine via the v1beta1 endpoint. I don't really feel strongly about disabling the group, since new data is actually being stored in v1beta1 format as of 1.6

[caesarxuchao]

I think it's because when stored to etcd, the path doesn't include the version, so as long as the codec is able to decode (i.e., v1lapha1 is registered to api.Scheme), it's readable.

[liggitt]

I knew the path was stable, but I thought we had already started cleaning up the shared global api.Scheme and you had to opt into the groups registered into your storage scheme, but apparently not

[caesarxuchao]

Some e2e tests rely on settings/v1alpha1 to be enabled by default:
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/47690/pull-kubernetes-e2e-gce-etcd3/36522/

PodPreset should create a pod preset 39s

[caesarxuchao]

@liggitt i think we can disable rbac and settings v1alpha1, reading v1alpha1 data is not an issue, but i need to fix the e2e tests depends on settings/v1alpha1.

[caesarxuchao]

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

[caesarxuchao]

Discussed with @pwittrock @foxish @dchen1107 offline, because there could be OSS users depending on rbac/v1alpha1 and setttings/v1alpha1 being enabled by default, in 1.7, we'll make an action-required release-note to inform people to enable these alpha features explicitly if needed, and will disable them by default in 1.8.

[liggitt]

Discussed with @pwittrock @foxish @dchen1107 offline, because there could be OSS users depending on rbac/v1alpha1 and setttings/v1alpha1 being enabled by default, in 1.7, we'll make an action-required release-note to inform people to enable these alpha features explicitly if needed, and will disable them by default in 1.8.

That seems more than reasonable. Can you add comments to the code as breadcrumbs to remind us and queue up the PR to do that in 1.8 so we don't forget?

[caesarxuchao]

Created #47691 as a reminder.

[caesarxuchao]

@liggitt could you also take a look at the release note? Thanks.

[dchen1107]

/lgtm

[caesarxuchao]

updated bazel.

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, dchen1107

Associated issue: 47687

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/master/OWNERS [dchen1107]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue