Fix Operation names for subresources

[mbohlool]

Subresources may have their kind but in operationID and description we should use their parent kind not their own kind. The subresource name represents subresources and no need to repeat in with their kind. e.g. Scale has kind of Scale and subresource name of Scale. This creates names like read scale of the specified Scale or readCoreV1NamespacedScaleScale for scale on replication controller. This PR fixes description and operation ID for them to read scale of the specified ReplicationController and readCoreV1NamespacedReplicationControllerScale.

@caesarxuchao I would like this to be patched in 1.7 too as it is useful for all clients and there is no need to wait for 1.8 for this documentation fix.

Fixed OpenAPI Description and Nickname of API objects with subresources

fixes #49250

[janetkuo]

This LGTM. Need to fix verification:

/go/src/k8s.io/kubernetes/federation/docs/api-reference is out of date. Please run hack/update-federation-api-reference-docs.sh

[caesarxuchao]

cc @wojtek-t our 1.7 patch branch manager for the cherrypick request.

[janetkuo]

/lgtm

[janetkuo]

/retest

[lavalamp]

/approve

[wojtek-t]

/retest

[wojtek-t]

Will create a cherrypick once this PR is merged.

[janetkuo]

/retest

[janetkuo]

Looks like you need to re-run some auto-gen scripts

[janetkuo]

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, lavalamp, mbohlool

Associated issue: 49250

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• api/OWNERS [lavalamp]
• docs/OWNERS [lavalamp]
• federation/OWNERS [lavalamp]
• staging/src/k8s.io/apiserver/OWNERS [lavalamp]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[janetkuo]

/test pull-kubernetes-kubemark-e2e-gce

[k8s-github-robot]

Automatic merge from submit-queue

[wojtek-t]

@caesarxuchao @mbohlool - it's not possible to automatically cherrypick it. If you want this cherrypicked, can you please prepare a cherrypick PR?

[k8s-cherrypick-bot]

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

[smarterclayton]

@Kargakis @deads2k this breaks openshift when introduced because we get this error:

F0909 13:11:59.007560   77320 openapi.go:38] Failed to register open api spec for root: Duplicate Operation ID createNamespacedDeploymentConfigRollback for path /oapi/v1/namespaces/{namespace}/deploymentconfigrollbacks and /oapi/v1/namespaces/{namespace}/deploymentconfigs/{name}/rollback.

It looks like we need to fix this to handle the case where the subresource name and the subresource kind are the same (i.e. DeploymentConfigRollback is the kind and has a top level representation, and there is a subresource of DeploymentConfig called rollback). If there's any open api aggregation going on, this would break as well, so the backport would need that fix as well.

[mbohlool]

What would you suggest the name should look like in this case?

[0xmichalis]

fwiw we should have deprecated/removed DeploymentConfigRollback some time ago @mfojtik @tnozicka

[smarterclayton]

Subresources aren't the same as regular resources, so some separation between the core resource and all sub resources would be appropriate.