make volumesInUse sorted in node status updates

[dixudx]

What this PR does / why we need it:

volumesInUse is not sent in a stable sort order. This will make node status patch requests larger than needed, and makes debugging nodes harder than necessary.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49731

Special notes for your reviewer:

/cc @derekwaynecarr @jboyd01

Release note:

make volumesInUse sorted in node status updates

[k8s-ci-robot]

@dixudx: GitHub didn't allow me to request PR reviews from the following users: jboyd01.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

volumesInUse is not sent in a stable sort order. This will make node status patch requests larger than needed, and makes debugging nodes harder than necessary.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49731

Special notes for your reviewer:

/cc @derekwaynecarr @jboyd01

Release note:

make volumesInUse sorted in node status updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dixudx]

/assign @saad-ali

[dixudx]

/assign @derekwaynecarr

[jboyd01]

LGTM @dixudx. When I looked at this issue a couple weeks ago I had the same change and was attempting to come up with a unit test to cover the code change. Not necessary for such a simple change but I thought it would be good.

[dixudx]

@saad-ali PTAL. I think this PR is ready for review. Thanks.

[derekwaynecarr]

/ok-to-test

[dixudx]

@saad-ali @derekchiang Need your /approval. Thanks.

[derekwaynecarr]

/lgtm
/approve

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, dixudx

Associated issue: 49731

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/kubelet/volumemanager/OWNERS [derekwaynecarr]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[dixudx]

/test pull-kubernetes-e2e-kops-aws

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 49849, 50334, 51414)