Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubectl get show uninitialized resources #50445

Closed
wants to merge 2 commits into from
Closed

Kubectl get show uninitialized resources #50445

wants to merge 2 commits into from

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Aug 10, 2017 •
edited

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49032

Special notes for your reviewer:
/assign @ahmetb @caesarxuchao

Release note:

add new flag "include-uninitialized" for kubectl get to show uninitialized resources

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dixudx
We suggest the following additional approver: liggitt

Assign the PR to them by writing /assign @liggitt in a comment when ready.

Associated issue: 49032

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 10, 2017
This was referenced Aug 10, 2017
Closed
Closed
@dixudx
Copy link
Member Author

dixudx commented Aug 10, 2017

/assign @mengqiy

@dixudx
Copy link
Member Author

dixudx commented Aug 10, 2017

/assign @smarterclayton

@dixudx dixudx force-pushed the kubectl_get_show_uninitialized_resources branch from b04dcf3 to 090f084 Compare August 10, 2017 13:10
@dixudx
Copy link
Member Author

dixudx commented Aug 10, 2017

@deads2k PTAL. Thanks.

@caesarxuchao
Copy link
Member

Thanks @dixudx. Let's see if people can reach consensus on #49035 (comment).

@dixudx
Copy link
Member Author

dixudx commented Aug 11, 2017 •
edited

@caesarxuchao Seems we've got a consensus on #49035. PTAL.

@dixudx dixudx force-pushed the kubectl_get_show_uninitialized_resources branch from 090f084 to 524ab20 Compare August 11, 2017 04:02
@dixudx dixudx mentioned this pull request Aug 11, 2017
Merged
@dixudx dixudx force-pushed the kubectl_get_show_uninitialized_resources branch from 524ab20 to bcecc44 Compare August 15, 2017 07:13
@mengqiy
Copy link
Member

mengqiy commented Aug 16, 2017

I will make a pass today.

@mengqiy
Copy link
Member

mengqiy commented Aug 16, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 16, 2017
@dixudx
Copy link
Member Author

dixudx commented Aug 17, 2017

@caesarxuchao @ahmetb Do we still need this PR, or in favor of #50497?

@dixudx dixudx force-pushed the kubectl_get_show_uninitialized_resources branch from bcecc44 to debc37b Compare August 17, 2017 02:08
@dixudx dixudx force-pushed the kubectl_get_show_uninitialized_resources branch from debc37b to 81f71f7 Compare August 17, 2017 03:49
@mengqiy
Copy link
Member

mengqiy commented Aug 17, 2017

If this PR is a subset of #50497, we can close this and please update #50497 PR body to close both issues.

@dixudx
Copy link
Member Author

dixudx commented Aug 17, 2017

Close this PR. In favor of #50497. Will reopen it if needed.

@dixudx dixudx closed this Aug 17, 2017
@dixudx dixudx deleted the kubectl_get_show_uninitialized_resources branch September 9, 2017 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ahmetb ahmetb

@smarterclayton smarterclayton

@mengqiy mengqiy

@caesarxuchao caesarxuchao

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubectl get: does not show uninitialized resources
7 participants
@dixudx @k8s-ci-robot @k8s-github-robot @caesarxuchao @mengqiy @ahmetb @smarterclayton