Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OutOfDisk from controllers #51294

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Remove OutOfDisk from controllers #51294

merged 1 commit into from
Sep 5, 2017

Conversation

dashpole
Copy link
Contributor

This is one of the working items for #48843 for 1.8.

This changes the scheduler and daemonset controllers to no longer respect the OutOfDisk condition. The kubelet has not published OutOfDisk=True since 1.5.
This still preserves the Toleration for the OutOfDisk condition, as (I think?) this is required for backwards compatibility. I added TODOs to remove this in 1.10.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2017
@dashpole
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 24, 2017
@dashpole
Copy link
Contributor Author

/test pull-kubernetes-federation-e2e-gce

@dashpole
Copy link
Contributor Author

cc @vishh

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2017
vishh
vishh approved these changes Aug 28, 2017
View reviewed changes
Copy link
Contributor

@vishh vishh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2017
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2017
@dashpole
Copy link
Contributor Author

/unassign @aveshagarwal @Kargakis
/assign @davidopp

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2017
@dashpole
Copy link
Contributor Author

dashpole commented Sep 1, 2017

/retest

@davidopp
Copy link
Member

davidopp commented Sep 1, 2017

/lgtm /approve

@dashpole
Copy link
Contributor Author

dashpole commented Sep 1, 2017

/unassign @davidopp
/assign @derekwaynecarr

@derekwaynecarr
Copy link
Member

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2017
@vishh
Copy link
Contributor

vishh commented Sep 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2017
@dashpole
Copy link
Contributor Author

dashpole commented Sep 1, 2017

/retest

@abgworrall abgworrall modified the milestone: v1.8 Sep 2, 2017
@dashpole
Copy link
Contributor Author

dashpole commented Sep 2, 2017

/test pull-kubernetes-e2e-kops-aws

@CaoShuFeng
Copy link
Contributor

/test pull-kubernetes-verify

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2017
@dashpole
Copy link
Contributor Author

dashpole commented Sep 5, 2017

rebased

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 5, 2017
@dims
Copy link
Member

dims commented Sep 5, 2017

reapplying lgtm after rebase, original lgtm was from @vishh

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, davidopp, derekwaynecarr, dims, vishh

Associated issue: 48843

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 51915, 51294, 51562, 51911)

@k8s-github-robot k8s-github-robot merged commit 4692555 into kubernetes:master Sep 5, 2017
@k8s-ci-robot
Copy link
Contributor

@dashpole: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 97ab99a link /test pull-kubernetes-unit
pull-kubernetes-e2e-kops-aws 97ab99a link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-federation-e2e-gce 97ab99a link /test pull-kubernetes-federation-e2e-gce
pull-kubernetes-e2e-gce-etcd3 97ab99a link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dashpole dashpole deleted the scheduler_remove_ood branch January 15, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishh vishh vishh approved these changes

Assignees

@dims dims

@derekwaynecarr derekwaynecarr

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet