Add KUBE_APISERVER_REQUEST_TIMEOUT_SEC env var. #51480
Conversation
mml
added
the
do-not-merge
k8s-ci-robot
added
size/S
|
/release-note none |
|
/retest |
mml
added
release-note-none
|
Reviewed the changes and compared them to some similar flags. All the changes look right. Maybe add to |
mml
force-pushed
the
timeout-flag
branch
2 times, most recently
from
032ec01
to
98a8e89
Compare
mml
added
cherrypick-candidate
and removed
do-not-merge
|
Removing label |
|
/assign @roberthbailey |
|
This plumbs the flag through but it isn't being used by anything (config-default / config-test). Do we plan to use it in any e2e tests? As an aside, it would be really nice to stop having to plumb new flags in via this method and start to switch the apiserver over to using component configuration. Even though daniel said in https://docs.google.com/document/d/17C2D1Ghgv40pWByevo0ih8T-18Q1GlxbR4gu1_ZKlPE/edit that moving to component config wouldn't address technical debt, every time we plumb through a new flag we are essentially adding new technical debt that will need to be addressed in the future. |
|
@roberthbailey the plumbing here is mainly to support setting it for GKE. I may have changed more than I needed to, but I also didn't want to provide no way for, say, a GCE cluster started with kube-up to tweak that flag. LMK if you would like me to reduce scope, or if I missed something. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mml, roberthbailey Associated issue: 51415 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/retest Review the full test history for this PR. |
1 similar comment
|
/retest Review the full test history for this PR. |
|
/retest |
If set, connect it to kube-apiserver's --request-timeout flag.
k8s-github-robot
removed
the
lgtm
mml
added
the
lgtm
|
kubernetes/test-infra#4195 |
|
Automatic merge from submit-queue (batch tested with PRs 51480, 49616, 50123, 50846, 50404) |
…-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of #51480 upstream release 1.6 If set, connect it to kube-apiserver's --request-timeout flag. Cherrypick of #51480 **What this PR does / why we need it**: Backporting to support Kubernetes users with slower internet connections that need the ability to increase this timeout. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
|
Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
|
Created PR #52384 to merge this into 1.7. |
Automatic merge from submit-queue (batch tested with PRs 52316, 52289, 52375) Small fix in salt manifest for kube-apiserver for request-timeout flag **What this PR does / why we need it**: Fixes a minor bug in salt manifest (typo from #51480) **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` xref: #51355
wojtek-t
added
the
cherry-pick-approved
#52316-upstream-release-1.7 Automatic merge from submit-queue Automated cherry pick of #51480 #52316 upstream release 1.7 Cherry pick of #51480 and #52316 on release-1.7. #51480 : Add KUBE_APISERVER_REQUEST_TIMEOUT_SEC env var. #52316 : Small fix in salt manifest for kube-apiserver for request-timeout flag @jpbetz
|
Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Cluster startup support for the flag added by #51415. I won't merge until that PR merges.
Bug: #51355
cc @jpbetz