-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCE: E2E test - supplied static IP for internal LBs #51669
Conversation
840f411
to
117ac61
Compare
This PR hasn't been active in 61 days. It will be closed in 28 days (Dec 31, 2017). cc @nicksardo You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days |
117ac61
to
a656a06
Compare
c1bcc14
to
be66cd4
Compare
/assign @bowei |
/retest |
/assign @MrHohn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @vishh |
/retest |
7bbe63f
to
aaa8918
Compare
aaa8918
to
c4be6ea
Compare
/test pull-kubernetes-e2e-gke |
/lgtm The gke pull job seems to be failing on many PRs. |
/test pull-kubernetes-e2e-gke |
c4be6ea
to
72f2073
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MrHohn, nicksardo If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nicksardo: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
72f2073
to
7fbaf3f
Compare
New changes are detected. LGTM label has been removed. |
Will need to add a deletion for internal addresses in https://github.com/kubernetes/kubernetes/blob/e49e3baa832986ba57e9d155333a9d49b0e13b32/cluster/gce/util.sh |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ILB test will now reserve an RFC 1918 address within the subnetwork and set the
loadBalancerIP
field of the K8s service. The test will know the service controller successfully syncs after the loadbalancer's external IP updates to said address.Release note: