Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating kubenet for CNI with IPv6 #52180

Closed
wants to merge 1 commit into from
Closed

Updating kubenet for CNI with IPv6 #52180

wants to merge 1 commit into from

Conversation

rpothier
Copy link

@rpothier rpothier commented Sep 8, 2017 •
edited
Loading

CNI has been updated with IPv6, and these changes allow
kubenet to use IPv6 with the latest CNI.

What this PR does / why we need it:
This updated the config sent to CNI to allow for using IPv6 with the latest CNI.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #52179

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 8, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @rpothier. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 8, 2017
@rpothier
Copy link
Author

rpothier commented Sep 8, 2017

/sig network
/area ipv6

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. area/ipv6 labels Sep 8, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 8, 2017
@xiangpengzhao
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 10, 2017
@feiskyer
Copy link
Member

Maybe wait a while for #51250?

@rpothier
Copy link
Author

@feiskyer Thanks for the review, waiting is one option, but I was hoping that this change
could go in ahead. This will allow anyone who wants to try out IPv6 to do so without having
to apply these changes, just the CNI binaries need updating. This will help in testing out IPv6 for the next release. IPv4 is unchanged, so is compatible with the current CNI versions.

@feiskyer
Copy link
Member

code freeze now, even without #51250, we still need to wait the queue reopen.

dcbw
dcbw suggested changes Sep 14, 2017
View reviewed changes
pkg/kubelet/network/kubenet/kubenet_linux.go Outdated
"type": "host-local",
"ranges": [
{
"subnet": "10.1.0.0/24",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we bother with IPv4 when we want IPv6? or do you intend to do dual-stack here? If we really want dual-stack, then we should plumb that through and not use a fake static IPv4 address.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the question is compatibility, since the JSON is now 0.3.0, that's not going to be compatible with some of the CNI binaries out there already. To be fully compatible, you'd want to run a VERSION request on the bridge plugin to see what it supports, and then based on the returned array select the correct configuration JSON.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcbw Thanks for the review. I will remove the IPv4.
Thanks for the suggestion on the VERSION, this seems cleaner, however, the problem I ran into is that with CNI version 0.6.0, the CNI spec version remained at 1.3.1, same as the previous. Is there some way we can detect the release version? If not is there a way to update CNI to output the release version?

squeed
squeed reviewed Oct 5, 2017
View reviewed changes
pkg/kubelet/network/kubenet/kubenet_linux.go Outdated
@@ -235,6 +235,27 @@ const NET_CONFIG_TEMPLATE = `{
}
}`

const NET_CONFIG_TEMPLATE_V6 = `{
"cniVersion": "0.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be 0.3.1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will update

@bowei
Copy link
Member

bowei commented Oct 24, 2017

Now that CNI 0.60 has been merged, is this PR still relevant?

@rpothier
Copy link
Author

@bowei I think it is still relevant as the template needs to be updated for IPv6
Do we still need to support the older CNI version? or can we assume everyone will be on the latest.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2017
@rpothier
Copy link
Author

rpothier commented Nov 1, 2017

/test pull-kubernetes-unit

@rpothier
Copy link
Author

rpothier commented Nov 2, 2017

/retest

Updating kubenet for CNI with IPv6
b65ce73 
CNI has been updated with IPv6, and these changes allow
kubenet to use IPv6 with the latest CNI.
@danehans
Copy link

danehans commented Nov 7, 2017

xref pod latency due to dad: #55247

luxas
luxas approved these changes Nov 15, 2017
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @kubernetes/sig-network-pr-reviews
/assign @thockin
for approval

@bowei
Copy link
Member

bowei commented Nov 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2017
@bowei
Copy link
Member

bowei commented Nov 16, 2017

/retest

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bowei, rpothier
We suggest the following additional approver: thockin

Assign the PR to them by writing /assign @thockin in a comment when ready.

Associated issue: 52179

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@thockin
Copy link
Member

thockin commented Nov 18, 2017

/retest

@thockin
Copy link
Member

thockin commented Nov 18, 2017

Assign back to me once it is ready for review/approval.

@thockin thockin removed their assignment Nov 18, 2017
@danehans
Copy link

/test pull-kubernetes-e2e-gce

@danehans
Copy link

@dcbw do you mind updating your review?

@danehans
Copy link

/retest

@k8s-ci-robot
Copy link
Contributor

@rpothier: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce 02397b3 link /test pull-kubernetes-federation-e2e-gce
pull-kubernetes-e2e-gce-device-plugin-gpu b65ce73 link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-e2e-gce b65ce73 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-kops-aws b65ce73 link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-kubemark-e2e-gce b65ce73 link /test pull-kubernetes-kubemark-e2e-gce
pull-kubernetes-node-e2e b65ce73 link /test pull-kubernetes-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danehans danehans mentioned this pull request Nov 22, 2017
Closed
@rpothier
Copy link
Author

This PR is superseded by #56245.

@rpothier rpothier closed this Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed left review comments

@dcbw dcbw dcbw requested changes

@luxas luxas luxas approved these changes

Assignees

@bowei bowei

@dcbw dcbw

Labels
area/ipv6 cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Kubenet with CNI v0.6.x for IPv6