Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #52933 #52946

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Automated cherry pick of #52933 #52946

merged 1 commit into from
Sep 25, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 23, 2017

Cherry pick of #52933 on release-1.8.

#52933: Preserve leading and trailing slashes on proxy subpaths

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 23, 2017
@liggitt
Copy link
Member Author

liggitt commented Sep 23, 2017

etcd flake
/retest

@liggitt liggitt added this to the v1.8 milestone Sep 23, 2017
@liggitt
Copy link
Member Author

liggitt commented Sep 23, 2017

#49548 flake
/retest

@liggitt liggitt assigned smarterclayton and abgworrall and unassigned lavalamp and thockin Sep 23, 2017
@liggitt liggitt added kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 23, 2017
@liggitt
Copy link
Member Author

liggitt commented Sep 24, 2017 •
edited

TestDevicePluginReRegistration flake (#52560)
/retest

@spiffxp
Copy link
Member

spiffxp commented Sep 25, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, spiffxp

Associated issue: 52933

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@abgworrall abgworrall added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 25, 2017
@liggitt
Copy link
Member Author

liggitt commented Sep 25, 2017

/retest

1 similar comment
@abgworrall
Copy link
Contributor

/retest

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 4dd73ef into kubernetes:release-1.8 Sep 25, 2017
@k8s-ci-robot
Copy link
Contributor

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-bazel 34efe23 link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@caesarxuchao caesarxuchao mentioned this pull request Oct 10, 2017
Closed
7 tasks
@liggitt liggitt deleted the automated-cherry-pick-of-#52933-upstream-release-1.8 branch April 22, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spiffxp spiffxp

@smarterclayton smarterclayton

@abgworrall abgworrall

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@liggitt @spiffxp @k8s-github-robot @abgworrall @k8s-ci-robot @lavalamp @smarterclayton @thockin