Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #52803: AllowPrivilegeEscalation: add validations #53003

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Cherry-pick #52803: AllowPrivilegeEscalation: add validations #53003

merged 1 commit into from
Sep 26, 2017

Conversation

jessfraz
Copy link
Contributor

Cherry-pick of #52803: AllowPrivilegeEscalation: add validations

Fixes #52454

@jessfraz
AllowPrivilegeEscalation: add validations for caps and privileged
6f1f4ac 
Signed-off-by: Jess Frazelle <acidburn@microsoft.com>
(cherry picked from commit 0ad51ed)
@jessfraz jessfraz added this to the v1.8 milestone Sep 25, 2017
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2017
@k8s-github-robot k8s-github-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 25, 2017
@jessfraz jessfraz mentioned this pull request Sep 25, 2017
Closed
@liggitt
Copy link
Member

liggitt commented Sep 25, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2017
@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 25, 2017
@liggitt liggitt added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Sep 25, 2017
@abgworrall
Copy link
Contributor

If someone wants to get regular approval for this, I can get on with the cherrypicking

@liggitt
Copy link
Member

liggitt commented Sep 25, 2017 •
edited

I consider the approval in #52803 transitive. The validation change is required before we ship 1.8

@liggitt liggitt added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2017
@abgworrall abgworrall added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 25, 2017
@abgworrall
Copy link
Contributor

Jolly good, that's your call to make :) cherrypick started.

@abgworrall
Copy link
Contributor

/test pull-kubernetes-e2e-gce-bazel

@tallclair
Copy link
Member

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jessfraz, liggitt, tallclair
We suggest the following additional approver: smarterclayton

Assign the PR to them by writing /assign @smarterclayton in a comment when ready.

Associated issue: 52803

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jessfraz
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-bazel

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit a3ab97b into kubernetes:release-1.8 Sep 26, 2017
@jessfraz jessfraz deleted the 1.8-cherry-pick branch September 26, 2017 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liggitt liggitt

@abgworrall abgworrall

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jessfraz @liggitt @abgworrall @tallclair @k8s-github-robot @smarterclayton @gmarek @k8s-ci-robot