Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #53443 #53460

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Automated cherry pick of #53443 #53460

merged 1 commit into from
Oct 5, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 4, 2017 •
edited

Cherry pick of #53443 on release-1.8.

Fixes an API compatibility issue in PodSecurityPolicy

#53443: Use pointer for PSP allow escalation

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2017
@k8s-github-robot k8s-github-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 4, 2017
@liggitt liggitt added this to the v1.8 milestone Oct 4, 2017
@liggitt liggitt added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Oct 4, 2017
@tallclair
Copy link
Member

/lgtm

Thanks for picking this up!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liggitt, tallclair
We suggest the following additional approver: smarterclayton

Assign the PR to them by writing /assign @smarterclayton in a comment when ready.

Associated issue: 53443

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dims dims mentioned this pull request Oct 4, 2017
Closed
@jessfraz
Copy link
Contributor

jessfraz commented Oct 5, 2017

Lgtm! Thanks!!

@liggitt
Copy link
Member Author

liggitt commented Oct 5, 2017 •
edited

master PR was approved, all changed packages have approval except generated docs change, tagging
@jpbetz for cherry-pick approval

@liggitt liggitt added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2017
@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Oct 5, 2017
@k8s-github-robot k8s-github-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 5, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 6d3c909 into kubernetes:release-1.8 Oct 5, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.8" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@k8s-ci-robot
Copy link
Contributor

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-gpu ec25801 link /test pull-kubernetes-e2e-gce-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt liggitt deleted the automated-cherry-pick-of-#53443-upstream-release-1.8 branch April 22, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpbetz jpbetz

@smarterclayton smarterclayton

@jessfraz jessfraz

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@liggitt @tallclair @k8s-github-robot @jessfraz @k8s-cherrypick-bot @k8s-ci-robot @jpbetz @smarterclayton @saad-ali @piosz