Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client and server versions to the e2e.test output. #53551

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Add client and server versions to the e2e.test output. #53551

merged 1 commit into from
Oct 10, 2017

Conversation

mml
Copy link
Contributor

@mml mml commented Oct 6, 2017 •
edited

Fixes #53502.

NONE

Sample output:

Oct  6 15:02:44.001: INFO: Client version: v1.9.0-alpha.1.737+3b1b19a1e2a9a4-dirty
Oct  6 15:02:44.039: INFO: Server version: v1.8.0

/assign @timothysc

@k8s-ci-robot
Copy link
Contributor

@mml: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 6, 2017
@mml mml mentioned this pull request Oct 9, 2017
Closed
@timothysc timothysc added sig/testing Categorizes an issue or PR as relevant to SIG Testing. cherrypick-candidate labels Oct 10, 2017
timothysc
timothysc approved these changes Oct 10, 2017
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

/cc @jpbetz - re cherry-pick to 1.8.1

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2017
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@timothysc timothysc added this to the v1.8 milestone Oct 10, 2017
@timothysc
Copy link
Member

/assign @ixdy for approval

@k8s-ci-robot
Copy link
Contributor

@timothysc: GitHub didn't allow me to assign the following users: approval, for.

Note that only kubernetes members can be assigned.

In response to this:

/assign @ixdy for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ixdy
Copy link
Member

ixdy commented Oct 10, 2017

it'd probably be good if we could get this into the metadata shown by gubernator, too, though I don't know exactly how to do that. @rmmh thoughts?

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mml, timothysc

Associated issue: 53502

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 52354, 52949, 53551). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 0d10184 into kubernetes:master Oct 10, 2017
@jpbetz jpbetz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 10, 2017
@jpbetz jpbetz removed this from the v1.8 milestone Oct 11, 2017
@jpbetz jpbetz removed cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Oct 11, 2017
@jpbetz jpbetz added this to the v1.8 milestone Oct 11, 2017
@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed cherrypick-candidate labels Oct 11, 2017
@jpbetz jpbetz mentioned this pull request Oct 11, 2017
Merged
@jpbetz jpbetz removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 11, 2017
k8s-github-robot pushed a commit that referenced this pull request Oct 11, 2017
Merge pull request #53699 from jpbetz/automated-cherry-pick-of-#53551-#…
6c5503e 
…53673-origin-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #53551 #53673

Cherry pick of #53551 #53673 on release-1.8.

#53551: Add client and server versions to the e2e.test output.
#53673: Fix to prevent downward api change break on older versions

**Release note**:
```
Prevent downward api-change from breaking on older version
```
@jpbetz jpbetz removed this from the v1.8 milestone Oct 11, 2017
@mml mml mentioned this pull request Oct 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

Assignees

@timothysc timothysc

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mml @k8s-ci-robot @k8s-cherrypick-bot @timothysc @ixdy @k8s-github-robot @jpbetz