Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix controller manager crash issue on a manually created azure k8s cluster #53694
Conversation
This comment has been minimized.
This comment has been minimized.
/lgtm |
This comment has been minimized.
This comment has been minimized.
Hi @jingxu97 , could you take a look, thx |
This comment has been minimized.
This comment has been minimized.
@jdumars could you approve by |
This comment has been minimized.
This comment has been minimized.
/approve no-issue |
This comment has been minimized.
This comment has been minimized.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, jdumars Associated issue requirement bypassed by: jdumars The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
This comment has been minimized.
This comment has been minimized.
/test all [submit-queue is verifying that this PR is safe to merge] |
This comment has been minimized.
This comment has been minimized.
@andyzhangx: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This comment has been minimized.
This comment has been minimized.
Automatic merge from submit-queue (batch tested with PRs 53694, 53919). If you want to cherry-pick this change to another branch, please follow the instructions here. |
6118a4b
into
kubernetes:master
andyzhangx commentedOct 11, 2017
•
edited by enisoc
What this PR does / why we need it:
fix controller manager crash issue on a manually created k8s cluster, it's due to availability set nil issue in azure loadbalancer
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #In the testing of a manually created k8s cluster, I found controller manager on master would crash in current scenario:
machine.AvailabilitySet
is nil which would cause controller manager crashSpecial notes for your reviewer:
@brendanburns @karataliu @JiangtianLi
Release note:
/sig azure