Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix controller manager crash issue on a manually created azure k8s cluster #53694

Merged
merged 1 commit into from Oct 16, 2017

Conversation

@andyzhangx
Copy link
Member

andyzhangx commented Oct 11, 2017

What this PR does / why we need it:
fix controller manager crash issue on a manually created k8s cluster, it's due to availability set nil issue in azure loadbalancer

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
In the testing of a manually created k8s cluster, I found controller manager on master would crash in current scenario:

  1. Use acs-engine to set up k8s 1.7.7 cluster (it's with an availability set)
  2. Manually add a node to the k8s cluster (without an availibity set in this VM)
  3. Set up a service and schedule the pod onto this newly added node
  4. controller manager would crash on master because although this k8s cluster has an availability set, the newly added node's machine.AvailabilitySet is nil which would cause controller manager crash

Special notes for your reviewer:
@brendanburns @karataliu @JiangtianLi

Release note:

Azure cloudprovider: Fix controller manager crash issue on a manually created k8s cluster.

/sig azure

@jdumars

This comment has been minimized.

Copy link
Member

jdumars commented Oct 11, 2017

/lgtm

@andyzhangx

This comment has been minimized.

Copy link
Member Author

andyzhangx commented Oct 13, 2017

Hi @jingxu97 , could you take a look, thx

@andyzhangx

This comment has been minimized.

Copy link
Member Author

andyzhangx commented Oct 16, 2017

@jdumars could you approve by /approve no-issue, thx

@jdumars

This comment has been minimized.

Copy link
Member

jdumars commented Oct 16, 2017

/approve no-issue

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Oct 16, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, jdumars

Associated issue requirement bypassed by: jdumars

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Oct 16, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 16, 2017

@andyzhangx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 6920141 link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Oct 16, 2017

Automatic merge from submit-queue (batch tested with PRs 53694, 53919). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6118a4b into kubernetes:master Oct 16, 2017
11 of 14 checks passed
11 of 14 checks passed
pull-kubernetes-unit Jenkins job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-unit
Details
pull-kubernetes-e2e-kubeadm-gce Parent Job Status Changed: Job triggered.
cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce-bazel Job succeeded.
Details
pull-kubernetes-e2e-gce-etcd3 Jenkins job succeeded.
Details
pull-kubernetes-e2e-gce-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Jenkins job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Jenkins job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-verify Jenkins job succeeded.
Details
@andyzhangx andyzhangx changed the title fix controller manager crash issue on a manually created k8s cluster fix controller manager crash issue on a manually created azure k8s cluster Oct 17, 2017
k8s-github-robot pushed a commit that referenced this pull request Oct 19, 2017
…3694-upstream-release-1.6

Automatic merge from submit-queue.

Automated cherry pick of #53694

Cherry pick of #53694 on release-1.6.

#53694: fix avset nil issue in azure loadbalancer
**Release note**:

```
fix controller manager crash issue on a manually created azure k8s cluster
```
k8s-github-robot pushed a commit that referenced this pull request Nov 6, 2017
Kubernetes Submit Queue
…3694-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #53694

Cherry pick of #53694 on release-1.8.

#53694: fix avset nil issue in azure loadbalancer
**Release note**:

```
Fix controller manager crash issue on a manually created azure k8s cluster
```
k8s-github-robot pushed a commit that referenced this pull request Nov 17, 2017
Kubernetes Submit Queue
…3694-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #53694

Cherry pick of #53694 on release-1.7.

#53694: fix avset nil issue in azure loadbalancer

**Release note**:

```
fix controller manager crash issue on a manually created azure k8s cluster
```
@andyzhangx andyzhangx deleted the andyzhangx:azure-avset-nil-fix branch May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.