Improve generated proxy URLs for cluster-info

[liggitt]

Fixes #53927

improves the output of kubectl cluster-info to print more qualified URLs, including changing the proxied scheme to https if the service port name is https or port number is 443

NONE

[liggitt]

@kubernetes/sig-cli-pr-reviews

[dims]

should the last parameter be port.Port?

[liggitt]

no, if you specify a number, that just gets turned back into the port name server-side:

kubernetes/pkg/registry/core/service/rest.go

Lines 388 to 406 in 2986b37

	// If a port *number* was specified, find the corresponding service port name
	if portNum, err := strconv.ParseInt(portStr, 10, 64); err == nil {
	svc, err := rs.registry.GetService(ctx, svcName, &metav1.GetOptions{})
	if err != nil {
	return nil, nil, err
	}
	found := false
	for _, svcPort := range svc.Spec.Ports {
	if int64(svcPort.Port) == portNum {
	// use the declared port's name
	portStr = svcPort.Name
	found = true
	break
	}
	}
	if !found {
	return nil, nil, errors.NewServiceUnavailable(fmt.Sprintf("no service port %d found for service %q", portNum, svcName))
	}
	}

[ericchiang]

Worth adding a comment? I thought this looked wrong too.

[dims]

Aha. thanks @liggitt

[liggitt]

Added comment

[ericchiang]

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ericchiang, liggitt

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/kubectl/OWNERS [liggitt]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.