Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestForgivenessAdmission. #55846

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Fix TestForgivenessAdmission. #55846

merged 1 commit into from
Nov 16, 2017

Conversation

rohitagarwal003
Copy link
Member

This test would never fail because Annotations were empty in all cases!

This was missed when Tolerations were moved from Annotations to be part of Pod.Spec in #38957.

/kind bug
/sig scheduling

Release note:

NONE

@rohitagarwal003
Fix TestForgivenessAdmission.
7119fe2 
This test would never fail because Annotations were empty in all cases!

This was missed when Tolerations were moved from Annotations to be part of Pod.Spec in kubernetes#38957.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 16, 2017
@rohitagarwal003
Copy link
Member Author

/cc @aveshagarwal

@rohitagarwal003
Copy link
Member Author

/retest

@rohitagarwal003
Copy link
Member Author

/retest

Ugh. So many flaky unit tests in test/integration/garbagecollector. #55652 (comment)

@deads2k
Copy link
Contributor

deads2k commented Nov 16, 2017

I'm not very familiar with the code in question. This looks plausible

/assign aveshagarwal
/unassign
/approve no-issue

@aveshagarwal I'll leave detailed review with you.

@k8s-ci-robot k8s-ci-robot assigned aveshagarwal and unassigned deads2k Nov 16, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2017
@aveshagarwal
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, deads2k, mindprince

Associated issue: 38957

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 55371, 55846). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 8823a83 into kubernetes:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

Assignees

@aveshagarwal aveshagarwal

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rohitagarwal003 @deads2k @aveshagarwal @k8s-github-robot @derekwaynecarr @k8s-ci-robot