Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #52322 upstream release 1.8 #56517

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Automated cherry pick of #52322 upstream release 1.8 #56517

merged 1 commit into from
Dec 1, 2017

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Nov 28, 2017 •
edited
Loading

Automated cherry pick of #52322 upstream release 1.8

#52322: Fixes issue where PVCs using standard StorageClass create PDs in disks in wrong zone in multi-zone GKE clusters

Fix a bug in GCE multizonal clusters where PersistentVolumes were sometimes created in zones without nodes.

@davidz627
Changed GetAllZones to only get zones with nodes that are currently r…
61246f0 
…unning (renamed to GetAllCurrentZones). Added E2E test to confirm this behavior.

Added node informer to cloud-provider controller to keep track of zones
with k8s nodes in them.
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 28, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 28, 2017
@davidz627
Copy link
Contributor Author

/assign msau42 wojtek-t liggitt

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 29, 2017
@msau42
Copy link
Member

msau42 commented Nov 29, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2017
@msau42
Copy link
Member

msau42 commented Nov 29, 2017

/release-note

@k8s-ci-robot
Copy link
Contributor

@msau42: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msau42
Copy link
Member

msau42 commented Nov 29, 2017

@davidz627 can you fix the release note formatting

@wojtek-t wojtek-t added this to the v1.8 milestone Nov 29, 2017
@wojtek-t
Copy link
Member

/approve no-issue

@wojtek-t
Copy link
Member

@jpbetz - can you please approve this cherrypick?

@wojtek-t wojtek-t assigned jpbetz and unassigned smarterclayton and jdef Nov 29, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42, wojtek-t

Associated issue: 52322

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. milestone/incomplete-labels labels Nov 29, 2017
@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 29, 2017
@davidz627
Copy link
Contributor Author

davidz627 commented Nov 30, 2017 •
edited
Loading

/sig storage
/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Nov 30, 2017
jpbetz
jpbetz approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request Current

@davidz627 @jpbetz @liggitt @msau42 @wojtek-t

Pull Request Labels
  • sig/storage: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit a2d9fa0 into kubernetes:release-1.8 Dec 1, 2017
@davidz627 davidz627 deleted the automated-cherry-pick-of-#52322-upstream-release-1.8 branch December 1, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz approved these changes

Assignees

@jpbetz jpbetz

@liggitt liggitt

@wojtek-t wojtek-t

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@davidz627 @msau42 @k8s-ci-robot @wojtek-t @k8s-github-robot @jpbetz @liggitt @smarterclayton @jdef