Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable flexvolume on Windows node #56921

Merged
merged 1 commit into from
Dec 16, 2017
Merged

enable flexvolume on Windows node #56921

merged 1 commit into from
Dec 16, 2017

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Dec 7, 2017 •
edited

What this PR does / why we need it:
enable flexvolume on Windows node:
current PodVolumeDir is like
\var\lib\kubelet\pods\f54c5a74-da63-11e7-b71a-000d3a02c330\volumes\test~hostpath.cmd\flextest
which is a unix path, with this PR, PodVolumeDir in windows kubelet will be converted into like
c:\var\lib\kubelet\pods\f54c5a74-da63-11e7-b71a-000d3a02c330\volumes\test~hostpath.cmd\flextest

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #56875

Special notes for your reviewer:
Detailed steps about how to use flexvolume on Windows with this PR:
https://github.com/andyzhangx/Demo/tree/master/windows/flexvolume

Release note:

enable flexvolume on Windows node

/sig windows

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2017
@andyzhangx
Copy link
Member Author

@brendandburns

@dixudx
Copy link
Member

dixudx commented Dec 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2017
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@andyzhangx
Copy link
Member Author

/assign @brendandburns

@brendandburns
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, brendandburns, dixudx

Associated issue: #56875

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2017
@k8s-github-robot
Copy link

/test all

Tests are more than 96 hours old. Re-running tests.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 56650, 55813, 56911, 56921, 56871). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit ea55d70 into kubernetes:master Dec 16, 2017
This was referenced Dec 18, 2017
Merged
Merged
Merged
k8s-github-robot pushed a commit that referenced this pull request Dec 20, 2017
Merge pull request #57307 from andyzhangx/automated-cherry-pick-of-#5…
4fd903a 
…6921-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #56921

Cherry pick of #56921 on release-1.8.

#56921: enable flexvolume on Windows
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@brendandburns brendandburns added this to the v1.10 milestone Jan 2, 2018
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

k8s-github-robot pushed a commit that referenced this pull request Jan 3, 2018
Merge pull request #57306 from andyzhangx/automated-cherry-pick-of-#5…
d15333e 
…6921-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #56921: enable flexvolume on Windows

Cherry pick of #56921 on release-1.9.

#56921: enable flexvolume on Windows

**Release note**:

```
enable flexvolume on Windows node
```
k8s-github-robot pushed a commit that referenced this pull request Jan 4, 2018
Merge pull request #57308 from andyzhangx/automated-cherry-pick-of-#5…
a2cf8cd 
…6921-upstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #56921

Cherry pick of #56921 on release-1.7.

#56921: enable flexvolume on Windows

**Release note**:

```
enable flexvolume on Windows node
```
@andyzhangx andyzhangx deleted the flexvolume-windows branch May 8, 2018 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tmrts tmrts

@dixudx dixudx

@brendandburns brendandburns

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.

FlexVolume does not work on Windows node
8 participants
@andyzhangx @dixudx @brendandburns @k8s-ci-robot @k8s-github-robot @k8s-cherrypick-bot @tmrts @saad-ali